It would be great if we can add some description to each paragraph type to define what could it be used for.
| Comment | File | Size | Author |
|---|---|---|---|
| #18 | interdiff-2873576-15-18.txt | 1.37 KB | aheredia |
| #18 | description-2873576-18.patch | 5.4 KB | aheredia |
| #16 | interdiff-2873576-7-15.txt | 964 bytes | aheredia |
| #15 | description-2873576-15.patch | 5.33 KB | aheredia |
| #11 | description-2873576-11.patch | 5.04 KB | aheredia |
Comments
Comment #2
aheredia commentedHere is the patch
Comment #3
aheredia commentedI've attached some screen shoots to clarify.
Comment #4
aheredia commentedComment #5
aheredia commentedComment #6
miro_dietikerAwesome, let's get this in.
But a littlebit of test coverage (one single desc, one single assert) is a requirement. :-)
Comment #7
aheredia commentedOk thanks
Here is the patch with the test coverage.
Comment #8
aheredia commentedComment #9
toncic commentedTested this and works fine. Just small improvements:
One extra blank line.
We can add here one more assert to check if $description is displayed in 'DESCRIPTION' column after saving.
Comment #10
aheredia commentedOk for the first
For the second I don't know exactly how to implement that. Could you give me some guidance on how to do it?
Thanks in advance.
Regards
Comment #11
aheredia commentedThis is the patch
Comment #12
aheredia commentedComment #14
aheredia commentedThe test is correct. Retesting and passing the test again
Comment #15
aheredia commentedFinally I managed to do it.
Here is the patch with the new test.
Comment #16
aheredia commentedAdded the interdiff betweent #7 #15
Comment #17
VladimirMarko commentedThe
@returndocumentation should beThe description of this paragraphs type..This checks that the description is under the description header, if both exists.
But it also passes, if there is no description and no description header.
What we need is a simple
.
Also, maybe it's better to rename
$headerto$header_positionand$rowto$row_position, or similar, to make it clearer in the variable names what is actually being checked here.Comment #18
aheredia commentedOk thanks.
Suggestions followed
Comment #19
aheredia commentedComment #20
VladimirMarko commentedI think this looks good.
Thank you for your work!
Comment #22
miro_dietikerVery nice, committed. :-)
Now let's add those descriptions to the existing demo / collection paragraph types.
Comment #23
aheredia commentedOk I'll try to go for them.
By the way I don't agree with author of the commit, i have made all the patches :(
Comment #25
miro_dietiker@aheredia I attributed VladimirMarko and toncic for reviewing the patches and giving feedback. That's a key type of contribution.
Even if you would provide 100% perfect patches and someone does a QUALIFIED review with proper statement and setting it to RTBC, i would attribute that person.
I seem to accidentally have switched the patch author to VladimirMarko, i intended to keep you there.
To "fix" authoring, i pushed an empty commit with the proper author setting, so it can show up in your commit list.
Comment #26
aheredia commentedI agree 100% with you.
Many thanks for the clarification.
Regards