Problem/Motivation

Not sure if this is intentional, but I don't think so. I usually set "default" as ContentEntityForm and as long as the link templates are set, the edit/add forms work fine.

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#8 2875896-8.patch4.81 KBsam152
#8 2875896-8-TEST-ONLY.patch4.07 KBsam152
#5 2875896-5.patch762 bytestimmillwood
#2 2875896-2.patch761 bytestimmillwood

Comments

Sam152 created an issue. See original summary.

timmillwood’s picture

timmillwood
Primary language English
Location 🏴󠁧󠁢󠁷󠁬󠁳󠁿 Wales, UK
commented
Issue tags: +Needs tests
StatusFileSize
new 2875896-2.patch761 bytes

I think this is something we inherited from Workbench moderation. This will become an issue once more entity types become revisionable, such as taxonomy_term which only has a default and delete form handler.

Here's an initial patch.

timmillwood’s picture

timmillwood
Primary language English
Location 🏴󠁧󠁢󠁷󠁬󠁳󠁿 Wales, UK
commented
Status: Active » Needs review

Status: Needs review » Needs work

The last submitted patch, 2: 2875896-2.patch, failed testing.

timmillwood’s picture

timmillwood
Primary language English
Location 🏴󠁧󠁢󠁷󠁬󠁳󠁿 Wales, UK
commented
Status: Needs work » Needs review
StatusFileSize
new 2875896-5.patch762 bytes

I should at least read a patch before I upload it.

sam152’s picture

sam152 commented
Status: Needs review » Needs work

This does the trick, but is it NW for tests? We'll get implicit test coverage once more core entity types become revisionable.

Version: 8.4.x-dev » 8.5.x-dev

Drupal 8.4.0-alpha1 will be released the week of July 31, 2017, which means new developments and disruptive changes should now be targeted against the 8.5.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

sam152’s picture

sam152 commented
Status: Needs work » Needs review
StatusFileSize
new 2875896-8-TEST-ONLY.patch4.07 KB
new 2875896-8.patch4.81 KB

Got around to writing a test case for this.

The last submitted patch, 8: 2875896-8-TEST-ONLY.patch, failed testing. View results

timmillwood’s picture

timmillwood
Primary language English
Location 🏴󠁧󠁢󠁷󠁬󠁳󠁿 Wales, UK
commented
Status: Needs review » Reviewed & tested by the community
Issue tags: -Needs tests

LGTM

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented 
+++ b/core/modules/content_moderation/src/ParamConverter/EntityRevisionConverter.php
@@ -75,7 +75,7 @@ protected function isEditFormPage(Route $route) {
+      return in_array($operation, ['default', 'edit']) && $entity_type && $entity_type->isRevisionable();

Normally I'd ask for the third argument to is_array here, because strings - but $operation is always a string here.

  • larowlan committed c9b3084 on 8.5.x 
    Issue #2875896 by Sam152, timmillwood: EntityRevisionConverter isn't...
larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented
Status: Reviewed & tested by the community » Fixed

Committed as c9b3084 and pushed to 8.5.x

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.