in WebformEntitySettingsForm.php there is a call to load user 1 in a form description. We have removed user 1 from our instances which while arguably rare, might cause others to have the fatal error - Fatal error: Call to a member function label() on null in .../modules/webform/src/WebformEntitySettingsForm.php on line 325 - as well.

I'd like to ask if it could be made more generic by loading the current logged in user instead. patch attached.

Thanks for considering!

CommentFileSizeAuthor
#2 make_generic_form_description.patch1.16 KBjrockowitz
make_generic_form_description.patch1.16 KBel1_1el

Comments

el1_1el created an issue. See original summary.

jrockowitz’s picture

jrockowitz commented
Priority: Minor » Normal
StatusFileSize
new make_generic_form_description.patch1.16 KB

@el1_1el You win the smallest and best patch of the week. I am re-uploading the patch just to get the automated tests to run.

This is not a minor since it can cause a 'Fatal error'.

  • jrockowitz committed 9073c52 on 8.x-5.x authored by el1_1el 
    Issue #2875013 by el1_1el: make form_prepopulate_source_entity...
jrockowitz’s picture

jrockowitz commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.