Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
You guys managed to commit something that doesn't work at all !
Issues:
- the logic for alt_login requires name to be defined! Since you just cut&pasted one of my lines, the result doesn't make sense.
The select never works.
- if you don't patch the auto-select part as well, the patch is of little use anyways, as you have to enter alt_login stuff manually...
Comment | File | Size | Author |
---|---|---|---|
#10 | 287496_alt_login_integration_10.patch | 2.16 KB | deviantintegral |
#8 | 287496_alt_login_integration.patch | 1.8 KB | deviantintegral |
#2 | masquerade.patch | 2.7 KB | espie |
#1 | masq.diff | 2.81 KB | espie |
Comments
Comment #1
espie CreditAttribution: espie commentedpatch attached, that makes it work with 1.2...
Comment #2
espie CreditAttribution: espie commentedFixed patch for 6.x, since I switched.
With this one, both auto-complete and actual changes work.
I think it's simpler than what's currently in.
Comment #3
deekayen CreditAttribution: deekayen commented#521444: Store user ID's instead of user names for quick switch links is a prereq to this
Comment #4
deviantintegral CreditAttribution: deviantintegral commentedPatch no longer applies.
Comment #5
espie CreditAttribution: espie commentedsigh, I'll work on another patch tomorrow.
But please stop postponing it or applying it in weird ways, it's a bit like having to fix the same bug over three times. It is getting annoying...
Comment #6
deviantintegral CreditAttribution: deviantintegral commentedFor sure - your patches are appreciated. I'd like to get this in to the next release of the module.
Comment #7
deviantintegral CreditAttribution: deviantintegral commentedI have an updated patch (untested) for this which I'll be posting later today.
Comment #8
deviantintegral CreditAttribution: deviantintegral commentedHere is an updated patch - can you let me know if it works for you?
Comment #9
deviantintegral CreditAttribution: deviantintegral commentedComment #10
deviantintegral CreditAttribution: deviantintegral commentedHere is a rerolled patch, with a minor code style change.
Comment #11
deviantintegral CreditAttribution: deviantintegral commentedI've committed this patch as it's works for me and is needed to fully fix the Anonymous users issue.
Comment #12
espie CreditAttribution: espie commentedsorry for not giving you feedback earlier. I got swamped in other issues.
Things appear to work just fine. Thanks a lot !