we have created patch related coding standard. please review

CommentFileSizeAuthor
#3 Before-Login-custom-field2.png101.55 KBriddhi.addweb
#3 Before-Login-custom-field1.png146.16 KBriddhi.addweb
#3 After-Login-custom-field.png56.92 KBriddhi.addweb
coding_standard-1.patch7.43 KBcmsminds

Comments

cmsMinds created an issue. See original summary.

samaphp’s picture

samaphp
Primary language Arabic
Location Riyadh, SA 🇸🇦
commented
Status: Active » Needs review

Please can you review the last version 1.1 ..
The standards has been covered by my colleague commit @3ssom

And thanks for your reviewing.

riddhi.addweb’s picture

riddhi.addweb commented
Assigned: cmsminds » Unassigned
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new After-Login-custom-field.png56.92 KB
new Before-Login-custom-field1.png146.16 KB
new Before-Login-custom-field2.png101.55 KB

Thanks for patch, I have checked your patch using coder module in simplytest.me and all warnings solved with patch.

PFA Screenshots for the same.

3ssom’s picture

3ssom commented
Assigned: Unassigned » 3ssom
3ssom’s picture

3ssom commented

Hello all,

there were more than this patch covered specially with the new update of v1.1 ..

so now everything is covered and I've made all necessary work regarding this.

Thank you all for your time

and great job @samaphp on this useful module and making it available to everyone :)

samaphp’s picture

samaphp
Primary language Arabic
Location Riyadh, SA 🇸🇦
commented
Status: Reviewed & tested by the community » Fixed

As per @3ssom reply, this task has been fixed.
Thanks all for cooperating <3

cmsminds’s picture

cmsminds
Location Raleigh, NC, United States
commented
samaphp’s picture

samaphp
Primary language Arabic
Location Riyadh, SA 🇸🇦
commented
Status: Fixed » Closed (fixed)