Hello,

In order for our webforms to be 508 compliant, we have to have a different page title on the webform confirmation page other than the node title. I saw that this change was introduced for 8.x version of this module, but we require it in the 7.x version.

CommentFileSizeAuthor
#10 webform-confirmation-page-title-2873880-10.patch3.58 KBchaseontheweb
#3 webform-confirmation-page-title-2873880-3.patch3.53 KBnathandentzau
#2 webform-confirmation-page-title-2873880-2.patch4.34 KBnathandentzau

Comments

nathandentzau created an issue. See original summary.

nathandentzau’s picture

nathandentzau
Location New York City
commented
StatusFileSize
new webform-confirmation-page-title-2873880-2.patch4.34 KB

Here's the patch.

nathandentzau’s picture

nathandentzau
Location New York City
commented
StatusFileSize
new webform-confirmation-page-title-2873880-3.patch3.53 KB

Whoops. Here's the patch without git diff color formatting. Sorry about that.

nathandentzau’s picture

nathandentzau
Location New York City
commented
nathandentzau’s picture

nathandentzau
Location New York City
commented
Status: Active » Needs review
liam morland’s picture

liam morland
Primary language English
Location Ontario, CA 🇨🇦
commented

Thanks for the patch. Can you add a test for this?

Do you know the issue number for this change in 8.5.x?

nathandentzau’s picture

nathandentzau
Location New York City
commented

Hey Liam,

Sure I can write tests. I looked briefly at the tests already in place and I didn't see where the project is testing the form fields in the webform settings page (unless I missed something). Here's the 8.x-5.x issue: https://www.drupal.org/node/2853302

liam morland’s picture

liam morland
Primary language English
Location Ontario, CA 🇨🇦
commented

It may not be testing that at all. Webform does not have wide test coverage. I'm hoping that changes will include tests being added when it is feasible.

chris matthews’s picture

chris matthews commented
Status: Needs review » Needs work
Issue tags: +Needs reroll
Related issues: +#2853302: Allow confirmation page title to be customized.

The 2 year old patch in #3 does not apply to webform.install on the latest 7.x-4.x-dev so will need a reroll.

Checking patch includes/webform.pages.inc...
Hunk #1 succeeded at 39 (offset -1 lines).
Hunk #2 succeeded at 444 (offset -1 lines).
Checking patch webform.install...
error: while searching for:

  return t('Webform emails may now be disabled.');
}

error: patch failed: webform.install:2351
error: webform.install: patch does not apply
Checking patch webform.module...
Hunk #1 succeeded at 1727 (offset 17 lines).
Hunk #2 succeeded at 3556 (offset 6 lines).
chaseontheweb’s picture

chaseontheweb
Location USA
commented
Status: Needs work » Needs review
StatusFileSize
new webform-confirmation-page-title-2873880-10.patch3.58 KB

Reroll of #3. Still no tests.

mably’s picture

mably commented
Issue tags: +Accessibility
liam morland’s picture

liam morland
Primary language English
Location Ontario, CA 🇨🇦
commented
Status: Needs review » Closed (outdated)

Drupal 7 is no longer supported. If this applies to a supported version, please re-open.

Now that this issue is closed, please review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, please credit people who helped resolve this issue.