Add Change record to @deprecated in ActiveTheme.php

best CR I could find is @see https://www.drupal.org/node/2497313

CommentFileSizeAuthor
#2 2873811_1.patch528 bytesjosephcheek
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

josephcheek created an issue. See original summary.

josephcheek’s picture

josephcheek
Location Provo, UT
CreditAttribution: josephcheek at TATA Consultancy Services commented
FileSize
2873811_1.patch528 bytes

patch attached

heddn’s picture

heddn
Primary language English
Location Nicaragua
CreditAttribution: heddn at MTech, LLC commented
Title: Add Change record to @deprecated in ActiveTheme.php » Add Change record to @deprecated in ActiveTheme
sorabh.v6’s picture

sorabh.v6
He/His
Primary language Hindi
CreditAttribution: sorabh.v6 at Acro Commerce commented
Status: Needs review » Reviewed & tested by the community

@see have been added to getStyleSheetsRemove. I confirm that no other @deprecated without @see is left in ActiveTheme.php

I'm setting to RTBC. Thanks All

Wim Leers’s picture

Wim Leers
Location Ghent 🇧🇪🇪🇺
CreditAttribution: Wim Leers at Acquia commented

👍

Although this could use a new section in the https://www.drupal.org/node/2497313 CR, to document which of these methods were deprecated. That was not done, because this is kind of an internal API, that almost no themer or module developer will ever actually use.

Leaving to core committer to judge.

  • catch committed 220f5d9 on 8.4.x 
    Issue #2873811 by josephcheek: Add Change record to @deprecated in...
catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch at Third and Grove commented
Status: Reviewed & tested by the community » Fixed

I think the existing CR is good enough, this probably should have been @internal in the first place.

Committed/pushed to 8.4.x, thanks!

Wim Leers’s picture

Wim Leers
Location Ghent 🇧🇪🇪🇺
CreditAttribution: Wim Leers at Acquia commented

this probably should have been @internal in the first place.

+1

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

kay_v’s picture

kay_v CreditAttribution: kay_v as a volunteer commented
Parent issue: #2873705: Add change records to all @deprecated code »

Removing parent issue per conversation with @xjm at Drupalcon Nashville Mentored Sprint prep. Her recommendation to do so was based on a few points that made sense to all of us in the discussion, namely:
- so many child issues makes this parent unwieldy
- search filters will allow people needing to refind closed children