Support from Acquia helps fund testing for Drupal Acquia logo

Comments

gpandher created an issue. See original summary.

gpandher’s picture

Added change record for @deprecated

Namespace change
\Drupal\migrate_drupal\MigrationCreationTrait\MigrationCreationTrait
to
\Drupal\migrate_drupal\MigrationCreationTrait\MigrationConfigurationTrait

heddn’s picture

Title: Add Change record to @deprecated for MigrationCreationTrait.php » Add Change record to @deprecated for MigrationCreationTrait
sorabh.v6’s picture

@see have been added to MigrationCreationTrait. I confirm that no other @deprecated without @see is left in MigrationCreationTrait.php

I'm setting to RTBC. Thanks All

sorabh.v6’s picture

Status: Active » Reviewed & tested by the community

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 2: 2873781-2.patch, failed testing. View results

jofitz’s picture

Assigned: gpandher » Unassigned
Status: Needs work » Needs review
FileSize
576 bytes

Patch not applying so re-rolled.

Mile23’s picture

Status: Needs review » Reviewed & tested by the community

MigrationCreationTrait was just renamed so there's nothing complicated here.

Adding this issue to the CR https://www.drupal.org/node/2873794

  • catch committed ed6bdc9 on 8.4.x
    Issue #2873781 by gpandher, Jo Fitzgerald: Add Change record to @...
catch’s picture

Status: Reviewed & tested by the community » Fixed

Committed ed6bdc9 and pushed to 8.4.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

kay_v’s picture

Removing parent issue per conversation with @xjm at Drupalcon Nashville Mentored Sprint prep. Her recommendation to do so was based on a few points that made sense to all of us in the discussion, namely:
- so many child issues makes this parent unwieldy
- search filters will allow people needing to refind closed children