CommentFileSizeAuthor
#7 2873781-7.patch576 bytesjofitz
#2 2873781-2.patch696 bytesgpandher

Comments

gpandher created an issue. See original summary.

gpandher’s picture

gpandher commented
StatusFileSize
new 2873781-2.patch696 bytes

Added change record for @deprecated

Namespace change
\Drupal\migrate_drupal\MigrationCreationTrait\MigrationCreationTrait
to
\Drupal\migrate_drupal\MigrationCreationTrait\MigrationConfigurationTrait

heddn’s picture

heddn
Primary language English
Location Illinois
commented
Title: Add Change record to @deprecated for MigrationCreationTrait.php » Add Change record to @deprecated for MigrationCreationTrait
sorabh.v6’s picture

sorabh.v6
He/His
Primary language Hindi
commented

@see have been added to MigrationCreationTrait. I confirm that no other @deprecated without @see is left in MigrationCreationTrait.php

I'm setting to RTBC. Thanks All

sorabh.v6’s picture

sorabh.v6
He/His
Primary language Hindi
commented
Status: Active » Reviewed & tested by the community

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 2: 2873781-2.patch, failed testing. View results

jofitz’s picture

jofitz
he/him
commented
Assigned: gpandher » Unassigned
Status: Needs work » Needs review
StatusFileSize
new 2873781-7.patch576 bytes

Patch not applying so re-rolled.

mile23’s picture

mile23
Primary language English
Location Seattle, WA
commented
Status: Needs review » Reviewed & tested by the community

MigrationCreationTrait was just renamed so there's nothing complicated here.

Adding this issue to the CR https://www.drupal.org/node/2873794

  • catch committed ed6bdc9 on 8.4.x 
    Issue #2873781 by gpandher, Jo Fitzgerald: Add Change record to @...
catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

Committed ed6bdc9 and pushed to 8.4.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

kay_v’s picture

kay_v commented
Parent issue: #2873705: Add change records to all @deprecated code »

Removing parent issue per conversation with @xjm at Drupalcon Nashville Mentored Sprint prep. Her recommendation to do so was based on a few points that made sense to all of us in the discussion, namely:
- so many child issues makes this parent unwieldy
- search filters will allow people needing to refind closed children