Closed (fixed)
Project:
Drupal core
Version:
8.4.x-dev
Component:
documentation
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
28 Apr 2017 at 16:06 UTC
Updated:
20 Apr 2018 at 19:17 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
eheller commentedComment #3
eheller commentedComment #4
eheller commentedComment #5
sorabh.v6Hey @eheller, @see have been added to
install_ensure_config_directory. I confirm that no other@deprecatedwithout@seeis left in install.incI'm setting to RTBC. Thanks All
Comment #7
dinesh18 commented#patch 2 doesn't seems to follow depreciation policy.
Comment #8
mile23#7: This issue is very limited in scope and is attempting to work on only some parts of deprecation.
git log -L520,540:core/includes/install.increveals that the @deprecation was added in #2466197: Staging directory should not have to be writeable., which does not have a change record.So we should add #2466197: Staging directory should not have to be writeable. to the list of related issues for change record https://www.drupal.org/node/2501187
Restarting the test of #2 since it was never tested.
Comment #10
angel.hAdded the issue to the change record and since the test on #2 passed I'm moving this to "Needs review".
Comment #11
angel.hComment #12
angel.hLooks fine -> RTBC.
Comment #13
janec commentedI'm at drupalcon Vienna and will try to add a @see for the deprecated install_ensure_config_directory() functionoeps. It's done already. Sorry.
Comment #14
mile23Added 8.5.x test to #2, to make sure it all works.
Comment #15
xjmComment #16
angel.hTest agains 8.5.x passed as well.
Comment #17
alexpottAccording to https://www.drupal.org/core/deprecation we should also be adding an
@trigger_error()to install_ensure_config_directory() - but we can't just do that because this method is used in \Drupal\simpletest\KernelTestBase::prepareConfigDirectories(). We need a follow-up issue to complete the deprecation of this method by removing the usages (just inlining the functionality into KernelTestBase::prepareConfigDirectories()) and to add the@trigger_error()call.Comment #18
alexpottI've created #2914033: Complete deprecation of install_ensure_config_directory()
Comment #19
catchCommitted/pushed to 8.5.x and cherry-picked to 8.4.x. Thanks!
Comment #22
alexpottNow we get on with #2914033: Complete deprecation of install_ensure_config_directory() - reviews appreciated.
Comment #24
kay_v commentedRemoving parent issue per conversation with @xjm at Drupalcon Nashville Mentored Sprint prep. Her recommendation to do so was based on a few points that made sense to all of us in the discussion, namely:
- so many child issues makes this parent unwieldy
- search filters will allow people needing to refind closed children