Give module needs to be converted to use short array syntax as per new coding standard.

CommentFileSizeAuthor
#7 Snap2.png244.25 KBzalak.addweb
#7 Snap1.png35.4 KBzalak.addweb
#6 convert_module_to_use-2872236-6.patch34.42 KBdhruveshdtripathi
#3 give_array_search_results.png141.58 KBdhruveshdtripathi
#2 short_array_syntax-2872236-2.patch37.76 KBMunavijayalakshmi

Comments

Munavijayalakshmi created an issue. See original summary.

Munavijayalakshmi’s picture

Munavijayalakshmi commented
Assigned: Munavijayalakshmi » Unassigned
Status: Active » Needs review
StatusFileSize
new short_array_syntax-2872236-2.patch37.76 KB
dhruveshdtripathi’s picture

dhruveshdtripathi commented
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new give_array_search_results.png141.58 KB

Patch applied cleanly. Arrays in the module converted to short array syntax. Few t() functions also converted to $this->t().

Excellent work!

mlncn’s picture

mlncn commented
Status: Reviewed & tested by the community » Needs work

Sorry, needs re-roll after David's work was brought in on May 1.

mlncn@t420:give [8.x-1.x]$ git apply short_array_syntax-2872236-2.patch
error: patch failed: src/Form/Donation/DonationEditForm.php:56
error: src/Form/Donation/DonationEditForm.php: patch does not apply
error: patch failed: src/Form/Donation/DonationForm.php:144
error: src/Form/Donation/DonationForm.php: patch does not apply
error: patch failed: src/Form/Donation/PaymentForm.php:97
error: src/Form/Donation/PaymentForm.php: patch does not apply

dhruveshdtripathi’s picture

dhruveshdtripathi commented
Assigned: Unassigned » dhruveshdtripathi
dhruveshdtripathi’s picture

dhruveshdtripathi commented
Status: Needs work » Needs review
StatusFileSize
new convert_module_to_use-2872236-6.patch34.42 KB

Updated patch

zalak.addweb’s picture

zalak.addweb commented
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new Snap1.png35.4 KB
new Snap2.png244.25 KB

@dhruveshdtripathi, Thanks for your patch it works as expected, I Checked it manually by applying your patch in module file. I have also verified your changes according to pareview.sh result. PFA

gnuget’s picture

gnuget
Primary language Spanish
commented

I rerolled your patch and commited it.

Thanks!!!

gnuget’s picture

gnuget
Primary language Spanish
commented
Status: Reviewed & tested by the community » Fixed
mlncn’s picture

mlncn commented

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.