Seems I broke the tests on Drupal 8.2 in the course of my monster cleanup in #2776659: Remove calls to deprecated Utility methods.

CommentFileSizeAuthor
#2 2870782-2--fix_tests_drupal_8_2.patch2.34 KBdrunken monkey

Comments

drunken monkey created an issue. See original summary.

drunken monkey’s picture

drunken monkey
he/him
Primary language German
Location Vienna, Austria
commented
Status: Active » Needs review
StatusFileSize
new 2870782-2--fix_tests_drupal_8_2.patch2.34 KB

Seems the @deprecated comment for NODE_[NOT_]PUBLISHED is misleading by not mentioning that this only got deprecated in 8.3.
We use the constants only in tests, however, so this will only make the tests fail on Drupal 8.2, not break the module itself in any way.

borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
commented

Instead of doing this, we should depend on 8.3 immediatly, it's been released so in theory there's no more 8.2.x releases coming.

drunken monkey’s picture

drunken monkey
he/him
Primary language German
Location Vienna, Austria
commented

Instead of doing this, we should depend on 8.3 immediatly, it's been released so in theory there's no more 8.2.x releases coming.

First off, in this specific case, this is just wrong: see this announcement.
Secondly, even if there are no further releases, people will not update right away, and they should still be able to use the Search API stable version right away.
So, fixing this and then requiring 8.3 as a next step, a bit after stable release (maybe when there's 8.3.2) seems like the better option to me.
Is that patch RTBC otherwise, in your opinion?

borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
commented
Status: Needs review » Reviewed & tested by the community

Sure, let's fix this and in a followup we can revert this patch and add the 8.3 dependency in a few weeks.

  • drunken monkey committed 583fefe on 8.x-1.x 
    Issue #2870782 by drunken monkey: Fixed the tests for Drupal 8.2.
drunken monkey’s picture

drunken monkey
he/him
Primary language German
Location Vienna, Austria
commented
Status: Reviewed & tested by the community » Fixed

Sure, let's fix this and in a followup we can revert this patch and add the 8.3 dependency in a few weeks.

OK, thanks!
Had that move planned anyways, just search the codebase for "Drupal 8.3". (There might be an issue already, but I'm not sure. Doesn't matter in any case, one of us will have to remember anyways once the next normal 8.3 release is out.)

In any case: committed.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.