Convert web tests to browser tests for field module

#2809483: Convert AJAX part of \Drupal\field\Tests\FormTest::testFieldFormJSAddMore to JavascriptTestBase has landed, so I have removed it 'postponed on' in the issue summary.

Does this issue still need the other 5 issues to be completed before it can be un-postponed? 2809483 was listed as the sole blocker on #2735005: Convert all Simpletest web tests to BrowserTestBase (or UnitTestBase/KernelTestBase)

#2809491: Convert AJAX part of \Drupal\field\Tests\Boolean\BooleanFieldTest::testBooleanField to JavascriptTestBase is now done. Removed it as a blocker.

only 1 test left to go

These blockers are done:
#2809489: Convert \Drupal\field\Tests\NestedFormTest to BrowserTestBase
#2809493: Convert AJAX part of \Drupal\field\Tests\Boolean\BooleanFormatterSettingsTest::testBooleanFormatterSettings to JavascriptTestBase
#2809499: Convert AJAX part of \Drupal\field\Tests\Number\NumberFieldTest to JavascriptTestBase
Updating IS to show the single blocker remaining.

Lets not postpone this, lets just put that last test out of scope.

Just some initial moves, added a CR for the deprecation.

We need to figure out what we want to do with \Drupal\field\Tests\EntityReference\EntityReferenceTestTrait, it's used in a lot of places, so lets not move it in this issue at least.

This should clean up some fails.

I found one nitpick.

+++ b/core/modules/field/src/Tests/Views/FieldTestBase.php
@@ -17,6 +19,11 @@
+ * @deprecated in Drupal 8.7.0. Will be removed before Drupal 9.0.0. U  se
+ * \Drupal\Tests\field\Functional\Views\FieldTestBase instead.

There seems to be 2 spaces in the word Use here.

@borisson_ thanks for reviewing! Fixed the nit.

Woo!

Committed and pushed 1950bd5f06 to 8.7.x and 9a7661ff23 to 8.6.x. Thanks!

diff --git a/core/modules/field/src/Tests/Views/FieldTestBase.php b/core/modules/field/src/Tests/Views/FieldTestBase.php
index edcd5299b2..6ae3b65546 100644
--- a/core/modules/field/src/Tests/Views/FieldTestBase.php
+++ b/core/modules/field/src/Tests/Views/FieldTestBase.php
@@ -2,7 +2,7 @@
 
 namespace Drupal\field\Tests\Views;
 
-@trigger_error( __NAMESPACE__ . '\FieldTestBase is deprecated in Drupal 8.7.0 and will be removed before Drupal 9.0.0. Instead, use \Drupal\Tests\field\Functional\Views\FieldTestBase. See https://www.drupal.org/node/2971931.', E_USER_DEPRECATED);
+@trigger_error(__NAMESPACE__ . '\FieldTestBase is deprecated in Drupal 8.6.0 and will be removed before Drupal 9.0.0. Instead, use \Drupal\Tests\field\Functional\Views\FieldTestBase. See https://www.drupal.org/node/2971931.', E_USER_DEPRECATED);
 
 use Drupal\field\Entity\FieldConfig;
 use Drupal\node\Entity\NodeType;
@@ -20,7 +20,7 @@
  *   - Use relationships between different entity types, for example node and
  *     the node author(user).
  *
- * @deprecated in Drupal 8.7.0. Will be removed before Drupal 9.0.0. Use
+ * @deprecated in Drupal 8.6.0. Will be removed before Drupal 9.0.0. Use
  * \Drupal\Tests\field\Functional\Views\FieldTestBase instead.
  *
  * @see https://www.drupal.org/node/2989020

Backported to 8.6.x to keep the tests aligned. And this is a test only change :) Also fixed

FILE: .../dev/drupal/core/modules/field/src/Tests/Views/FieldTestBase.php
----------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------
 5 | ERROR | [x] There should be no white space after an opening "("
----------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------