Closed (fixed)
Project:
Drupal core
Version:
8.5.x-dev
Component:
field system
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
30 Sep 2016 at 16:24 UTC
Updated:
15 Feb 2018 at 12:44 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #3
michielnugter commentedComment #5
ApacheEx commentedHere is a patch :)
Comment #6
ApacheEx commentedBased on @dawehner review in previous issues here is updated patch.
Comment #7
lendudeAlready looking nice, but couple of things:
This is a replacement for setRawContent() which is something we only do in Kernel tests now. So, either that has to be taken out and moved to a kernel test, or we should try to find a way to do that render on a URL we can call. The latter would be better since then we have an actual functional test. Doesn't entity_test have a detail view we can render this field on?
All 'waitfor' methods should be followed by an assertion that the element is actually on the page, otherwise we might just be waiting 10 seconds for nothing.
I think all the other waits already have this, just missed this one :)
Comment #8
ApacheEx commentedI'm surprized that whole
BooleanFieldTestcan be converted toBrowserTestBase:) So, no Javascript dependency.Here is a patch.
p.s. Based on @vaplas comment here #2809493: Convert AJAX part of \Drupal\field\Tests\Boolean\BooleanFormatterSettingsTest::testBooleanFormatterSettings to JavascriptTestBase
Comment #10
dawehner@ApacheEx
I guess this really shows that our no JS fallback work, I think that's enough. Boolean fields don't actually add anything custom ajax wise to those forms.
Comment #12
ApacheEx commentedAgree, thanks for review. Here is re-rolled patch with 8.6.x.
Comment #13
ApacheEx commentedComment #15
ApacheEx commentedRe-rolled patch was failed first time because of some another unrelated issue, now it's passed. Moved again to RTBC based on #10
Comment #18
catchCommitted/pushed to 8.6.x and cherry-picked to 8.5.x. Thanks!