Argument 5 passed to Drupal\webform\WebformHandlerBase::__construct() must implement interface Drupal\Core\Entity\EntityTypeManagerInterface, none given, called in modules/webform_mailchimp/src/Plugin/WebformHandler/WebformMailChimpHandler.php on line 29 and defined in Drupal\webform\WebformHandlerBase->__construct() (line 73 of /modules/webform/src/WebformHandlerBase.php)

CommentFileSizeAuthor
#13 webform_mailchimp-different_constructor_signature_beta13-2870129-13.patch1.57 KBhanoii
#3 webform_mailchimp-fix-handler-2870129-3.patch1.43 KBautopoietic

Comments

achandel created an issue. See original summary.

hendrik.fuss’s picture

hendrik.fuss commented

same issue here, with core 8.3.0

autopoietic’s picture

autopoietic commented
StatusFileSize
new webform_mailchimp-fix-handler-2870129-3.patch1.43 KB

WebformHandlerBase constructor is expecting an additional parameter. I have attached a patch to resolve this.

autopoietic’s picture

autopoietic commented
Status: Active » Needs review
hendrik.fuss’s picture

hendrik.fuss commented

Patch works for me, thanks!

(Can't get to select the email field now, but that's another issue. Will investigate.)

autopoietic’s picture

autopoietic commented
Status: Needs review » Reviewed & tested by the community
johnhanley’s picture

johnhanley commented

Patch +1

metakel’s picture

metakel commented

The patch works for me. Thank you!

cmckay’s picture

cmckay commented

Has this been rolled into dev as yet?

cmckay’s picture

cmckay commented

After adding the patch, I am getting ResponseText: Recoverable fatal error: Argument 5 passed to Drupal\webform\WebformHandlerBase::__construct() must implement interface Drupal\Core\Config\ConfigFactoryInterface, instance of Drupal\Core\Entity\EntityTypeManager given

cmckay’s picture

cmckay commented
Status: Reviewed & tested by the community » Active

Was able to reproduce this on a fresh install on Simplytest, changing this to active.

chismen’s picture

chismen commented

Same error, with patch:

Webform 8.x-5.0-beta13 and Webform mailchimp 8.x 5.0

TypeError: Argument 5 passed to Drupal\webform\WebformHandlerBase::__construct() must implement interface Drupal\Core\Config\ConfigFactoryInterface, instance of Drupal\Core\Entity\EntityTypeManager given, called in /var/www/igasesores.dev/modules/webform_mailchimp/src/Plugin/WebformHandler/WebformMailChimpHandler.php on line 30 in Drupal\webform\WebformHandlerBase->__construct() (line 97 of modules/webform/src/WebformHandlerBase.php).

hanoii’s picture

hanoii
Primary language Spanish
Location 🇦🇷UTC-3
commented
Priority: Normal » Critical
Status: Active » Needs review
StatusFileSize
new webform_mailchimp-different_constructor_signature_beta13-2870129-13.patch1.57 KB

beta13 changed the constructor signature even more

hanoii’s picture

hanoii
Primary language Spanish
Location 🇦🇷UTC-3
commented
Parent issue: » #2883538: Several improvements / Request for co-maintainership

This is also included in #2883538: Several improvements / Request for co-maintainership among other features. If possible a try of that patch could help get most features in.

cmckay’s picture

cmckay commented

@hanoii Thanks for tackling these issues! i can confirm that this patch fixed this issue.

georgi777’s picture

georgi777 commented
Status: Needs review » Reviewed & tested by the community

@hanoii's patch is working.

helonaut’s picture

helonaut commented

Confirmed, @hanoii's patch is indeed working: patch in #13 fixes the issue
Can we add this patch to the main branch / get it published? How can we propose this?

hanoii’s picture

hanoii
Primary language Spanish
Location 🇦🇷UTC-3
commented

I was added as a maintainer, I will add these patches in very soon.

hanoii’s picture

hanoii
Primary language Spanish
Location 🇦🇷UTC-3
commented
Status: Reviewed & tested by the community » Fixed

Committed the parent issue, will release a new version in a bit.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

bsnodgrass’s picture

bsnodgrass commented

Confirming this patch appears to have been rolled into future versions. Just installed 8.x-5.2 and Webform 8.x-5.0-beta15 (which had a DB update error, see: https://www.drupal.org/node/2896357 if you experience "webform_update_8060 Table webform already exists error"

Thanks for the great work on webform module! and webform_mailchimp!