Problem/Motivation

Simple logic bug in calculate dependencies. When no roles are used in the filter, there are no dependencies.

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Comments

Sam152 created an issue. See original summary.

Sam152’s picture

Status: Active » Needs review
Issue tags: +Needs tests, +Novice
FileSize
673 bytes
kristiaanvandeneynde’s picture

Status: Needs review » Needs work

Code looks good! Needs work for not having a test.

You should be able to pull it off rather easily by adding to \Drupal\Tests\user\Kernel\Views\HandlerFilterRolesTest::testDependencies()