Closed (fixed)
Project:
Drupal core
Version:
8.4.x-dev
Component:
views.module
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
12 Apr 2017 at 04:49 UTC
Updated:
30 May 2017 at 15:12 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
sam152 commentedComment #3
kristiaanvandeneyndeCode looks good! Needs work for not having a test.
You should be able to pull it off rather easily by adding to
\Drupal\Tests\user\Kernel\Views\HandlerFilterRolesTest::testDependencies()Comment #4
benjifisherComment #5
brendon commentedWhile attempting to provide tests I was unable to reproduce the issue. I was unable to find the empty/not empty operator in the filter. Could you add steps to reproduce?
Comment #6
mikeker commentedUpdated the issue summary with steps to reproduce.
Comment #7
erozqba commentedComment #8
sam152 commentedTest only patch to verify the test catches the bug.
Comment #10
sam152 commentedTest looks good. +1 to RTBC.
Comment #11
erozqba commentedAdd a test for not empty too.
Comment #12
mikeker commentedI've verified the patch in #11 using the STR in the issue summary and the config dependency is removed as expected. We've got a patch, we've got tests, I say we're RTBC.
Comment #13
kristiaanvandeneyndeYup, looks good. Nice work!
Comment #16
catchCommitted/pushed to 8.4.x and cherry-picked to 8.3.x. Thanks!
Comment #18
wim leersSomebody who worked on this may be able to resolve the conflict in #2846614: Incorrect field name is used in views integration for multi-value base fields that this introduced.