Closed (fixed)
Project:
TMGMT Extension Suite
Version:
8.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Task
Assigned:
Reporter:
Created:
5 Apr 2017 at 08:52 UTC
Updated:
26 Apr 2017 at 14:25 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
loparev commentedComment #3
loparev commentedAdded accepted state as a filter
Comment #4
soul88Please use strict comparison
is_reopen_needed is boolean. Why do we need "empty" function here?
Comment #5
loparev commentedFixed review comments + added service "UniqueQueueItem". Also refactored adding items into download and check status queues (with new services).
Comment #6
loparev commentedComment #7
loparev commentedAdded hook update for old continuous jobs
Comment #8
loparev commentedOne more patch
Comment #9
loparev commentedFinal one
Comment #10
loparev commentedSorry, here is a correct one
Comment #11
loparev commentedFixed error in Download queue worker
Comment #12
loparev commentedFixed problem with downloading of untranslated strings: check if job is ready for download inside of check status worker. Plus fixed possible issue with duplicated queue items in check status queue and as a consequence download queue (type casting to int)
Comment #13
soul88Why do we need this filter here? Should we ignore the "INACTIVE" state?
Comment #14
loparev commentedI think we have to. But..maybe it would be better to filter not job items but jobs? We are interested only in ACTIVE and FINISHED jobs.
BTW here is a patch that fixes a problem when job item hash isn't updated when it's state != new state.
Comment #15
loparev commentedFixed filters
Comment #16
soul88We don't use JobItem::setState() because it doesn't always call JobItem::save(), and so the behaviour might be inconsistent.
Comment #17
loparev commentedFix after review
Comment #18
loparev commentedComment #19
loparev commentedAdded tests
Comment #20
loparev commentedComment #21
loparev commentedUpload queue support for clone job form.
Comment #22
loparev commentedFixed bug with "one job - many job items" case - wrong condition for JOIN statement. It was invisible for "one to one" case.
Comment #24
loparev commented