External links added through link module, in the following format https://patents.google.com/?q=test+search+param are being treated as http://localhost/test+search+param due to call to drupal_parse_url() in _linkchecker_parse_fields().

So these links are showing up as 404.

CommentFileSizeAuthor
#3 linkchecker-external-urls-skip-drupal-parse-url-2866740-1.patch1.23 KBrwaery.11
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

rwaery.11 created an issue. See original summary.

rwaery.11’s picture

rwaery.11 CreditAttribution: rwaery.11 commented
Issue summary: View changes
rwaery.11’s picture

rwaery.11 CreditAttribution: rwaery.11 commented
FileSize
linkchecker-external-urls-skip-drupal-parse-url-2866740-1.patch1.23 KB
rwaery.11’s picture

rwaery.11 CreditAttribution: rwaery.11 commented
Status: Active » Needs review

Status: Needs review » Needs work

The last submitted patch, 3: linkchecker-external-urls-skip-drupal-parse-url-2866740-1.patch, failed testing.

rwaery.11’s picture

rwaery.11 CreditAttribution: rwaery.11 commented
Status: Needs work » Needs review
hass’s picture

hass CreditAttribution: hass commented
Version: 7.x-1.3 » 7.x-1.x-dev
Issue tags: -external links

Status: Needs review » Needs work

The last submitted patch, 3: linkchecker-external-urls-skip-drupal-parse-url-2866740-1.patch, failed testing.

hass’s picture

hass CreditAttribution: hass commented

Code style issues and no documentation why this is needed.

joseph.olstad’s picture

joseph.olstad
Primary language French
CreditAttribution: joseph.olstad commented

this might also affect D8

eiriksm’s picture

eiriksm
he/him
Primary language Norwegian Bokmål
Location Norway
CreditAttribution: eiriksm at Ny Media AS, Violinist commented

This does not affect D8. Tried to add the link in the issue summary, and it was checked and gave a 200.

The patch still needs work though.

It would be great to clean up the coding standards and document the change somewhat better, as suggested in #9.