Add Quick Edit off canvas form.

@tedbow I will look into the issue.

The webform modal dialog use a #ajax callback with the submit button to prevent validation errors from exiting the modal dialog.

The WebformDialogTrait::redirectForm probably just needs to account for the ?destination parameter.

This looks really cool.

A few tweaks

• I merged your quick edit form tweaks into the WebformUiEntityForm and created a WebformUiEntityForm::isQuickEdit method. I am hoping this makes things easier.
• I removing the element operations column from the quick edit form because the element's title opens each element's edit dialog.

A few thoughts..

• We might need a helper method to pass the ?destination parameter from one quick edit form/dialog to another.
• Save buttons maybe need to moved (or replicated) to the top of each quick edit form.

One issue.

• Locally I have Drupal running in a subdirectory and the quick edit link is missing the base path.
• ?destination=webform/contact should be ?destination=/BASE_PATH/webform/contact

#2752637: hook_contextual_links_view_alter not getting called. just made me lose patience trying to work on this but I was able to completely fix ?destination issues using a PathProcessor. I was going to be an impossible task tracking every dialogs URL and passing the ?destination between links.

Personally, I would like to remove all the entity.webform.quick_edit_form code and alter the WebformUiEntityForm based on the "?_wrapper_format' query string parameter.

The #2752637: hook_contextual_links_view_alter not getting called. issue made it really hard to begin this refactoring.

I created a dedicated branch so that I can easily track changes and quickly get an MVP working before DrupalCon.

Adding reference to #2773591: New contextual links are not available after a module is installed which is making it difficult to see changes to contextual links.

Attached is an MVP that I would be okay with committing to force more eyeballs to look at the Webform module's quick edit and system tray integration.

@tedbow I am not seeing how to detect if offcanvas or off_canvas should be used.

I am okay tracking the main issue and doing the renaming of offcanvas to off_canvas, when needed.

@tedbow I am thinking version detection might be enough if #2862625: Rename offcanvas to two words in code and comments. is committed to 8.4.x and I can just assume 8.3.x installations should use 'offcanvas' and anyone using 8.4.x is using the latest dev release which should use 'off_canvas'.

Re-rolling with latest merges

Fixing some minor UX bugs.

Here is my hack to detect offcanvas vs off_canvas.

  /**
   * Off canvas trigger name.
   *
   * @var string
   */
  protected static $offCanvasTriggerName;

  /**
   * Get Off canvas trigger name.
   *
   * @return string
   *   The off canvas trigger name.
   *
   * @see Issue #2862625: Rename offcanvas to two words in code and comments.
   * @see https://www.drupal.org/node/2862625
   */
  public static function getOffCanvasTriggerName() {
    if (isset(self::$offCanvasTriggerName)) {
      return self::$offCanvasTriggerName;
    }

    if (file_exists(drupal_get_path('module', 'outside_in') .'/css/off-canvas.css')) {
      self::$offCanvasTriggerName = 'off_canvas';
    }
    else {
      self::$offCanvasTriggerName = 'offcanvas';
    }

    return self::$offCanvasTriggerName;
  }

I am very tempted to commit the patch and do a screencast before DrupalCon.

This looks good, but if the Settings Tray module isn't enabled, I get a lot of notices in my logs, at least on PHP 5.6. (Enabling it suppresses this message.)

Notice: Undefined index: destination in Drupal\webform_ui\PathProcessor\WebformUiPathProcessor->processOutbound() (line 28 of /var/www/connect.mitacs.ca/modules/contrib/webform/modules/webform_ui/src/PathProcessor/WebformUiPathProcessor.php) #0 /var/www/connect.mitacs.ca/core/includes/bootstrap.inc(552): _drupal_error_handler_real(8, 'Undefined index...', '/var/www/connec...', 28, Array) #1 /var/www/connect.mitacs.ca/modules/contrib/webform/modules/webform_ui/src/PathProcessor/WebformUiPathProcessor.php(28): _drupal_error_handler(8, 'Undefined index...', '/var/www/connec...', 28, Array) #2 /var/www/connect.mitacs.ca/core/lib/Drupal/Core/PathProcessor/PathProcessorManager.php(109): Drupal\webform_ui\PathProcessor\WebformUiPathProcessor->processOutbound('/admin/structur...', Array, Object(Symfony\Component\HttpFoundation\Request), Object(Drupal\Core\GeneratedUrl)) #3 /var/www/connect.mitacs.ca/core/lib/Drupal/Core/Routing/UrlGenerator.php(382): Drupal\Core\PathProcessor\PathProcessorManager->processOutbound('/admin/structur...', Array, Object(Symfony\Component\HttpFoundation\Request), Object(Drupal\Core\GeneratedUrl)) #4 /var/www/connect.mitacs.ca/core/lib/Drupal/Core/Routing/UrlGenerator.php(296): Drupal\Core\Routing\UrlGenerator->processPath('/admin/structur...', Array, Object(Drupal\Core\GeneratedUrl)) #5 /var/www/connect.mitacs.ca/core/lib/Drupal/Core/Render/MetadataBubblingUrlGenerator.php(105): Drupal\Core\Routing\UrlGenerator->generateFromRoute('<current>', Array, Array, true) #6 /var/www/connect.mitacs.ca/core/lib/Drupal/Core/Url.php(753): Drupal\Core\Render\MetadataBubblingUrlGenerator->generateFromRoute('<current>', Array, Array, true) #7 /var/www/connect.mitacs.ca/core/lib/Drupal/Core/Render/Element/RenderElement.php(359): Drupal\Core\Url->toString(true) #8 /var/www/connect.mitacs.ca/core/lib/Drupal/Core/Render/Element/RenderElement.php(229): Drupal\Core\Render\Element\RenderElement::preRenderAjaxForm(Array) #9 [internal function]: Drupal\Core\Render\Element\RenderElement::processAjaxForm(Array, Object(Drupal\Core\Form\FormState), Array) #10 /var/www/connect.mitacs.ca/core/lib/Drupal/Core/Form/FormBuilder.php(982): call_user_func_array(Array, Array) #11 /var/www/connect.mitacs.ca/core/lib/Drupal/Core/Form/FormBuilder.php(1045): Drupal\Core\Form\FormBuilder->doBuildForm('webform_ui_elem...', Array, Object(Drupal\Core\Form\FormState)) #12 /var/www/connect.mitacs.ca/core/lib/Drupal/Core/Form/FormBuilder.php(1045): Drupal\Core\Form\FormBuilder->doBuildForm('webform_ui_elem...', Array, Object(Drupal\Core\Form\FormState)) #13 /var/www/connect.mitacs.ca/core/lib/Drupal/Core/Form/FormBuilder.php(1045): Drupal\Core\Form\FormBuilder->doBuildForm('webform_ui_elem...', Array, Object(Drupal\Core\Form\FormState)) #14 /var/www/connect.mitacs.ca/core/lib/Drupal/Core/Form/FormBuilder.php(1045): Drupal\Core\Form\FormBuilder->doBuildForm('webform_ui_elem...', Array, Object(Drupal\Core\Form\FormState)) #15 /var/www/connect.mitacs.ca/core/lib/Drupal/Core/Form/FormBuilder.php(1045): Drupal\Core\Form\FormBuilder->doBuildForm('webform_ui_elem...', Array, Object(Drupal\Core\Form\FormState)) #16 /var/www/connect.mitacs.ca/core/lib/Drupal/Core/Form/FormBuilder.php(1045): Drupal\Core\Form\FormBuilder->doBuildForm('webform_ui_elem...', Array, Object(Drupal\Core\Form\FormState)) #17 /var/www/connect.mitacs.ca/core/lib/Drupal/Core/Form/FormBuilder.php(1045): Drupal\Core\Form\FormBuilder->doBuildForm('webform_ui_elem...', Array, Object(Drupal\Core\Form\FormState)) #18 /var/www/connect.mitacs.ca/core/lib/Drupal/Core/Form/FormBuilder.php(557): Drupal\Core\Form\FormBuilder->doBuildForm('webform_ui_elem...', Array, Object(Drupal\Core\Form\FormState)) #19 /var/www/connect.mitacs.ca/core/lib/Drupal/Core/Form/FormBuilder.php(314): Drupal\Core\Form\FormBuilder->processForm('webform_ui_elem...', Array, Object(Drupal\Core\Form\FormState)) #20 /var/www/connect.mitacs.ca/core/lib/Drupal/Core/Controller/FormController.php(74): Drupal\Core\Form\FormBuilder->buildForm(Object(Drupal\webform_ui\Form\WebformUiElementEditForm), Object(Drupal\Core\Form\FormState)) #21 [internal function]: Drupal\Core\Controller\FormController->getContentResult(Object(Symfony\Component\HttpFoundation\Request), Object(Drupal\Core\Routing\RouteMatch)) #22 /var/www/connect.mitacs.ca/core/lib/Drupal/Core/EventSubscriber/EarlyRenderingControllerWrapperSubscriber.php(123): call_user_func_array(Array, Array) #23 /var/www/connect.mitacs.ca/core/lib/Drupal/Core/Render/Renderer.php(574): Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->Drupal\Core\EventSubscriber\{closure}() #24 /var/www/connect.mitacs.ca/core/lib/Drupal/Core/EventSubscriber/EarlyRenderingControllerWrapperSubscriber.php(124): Drupal\Core\Render\Renderer->executeInRenderContext(Object(Drupal\Core\Render\RenderContext), Object(Closure)) #25 /var/www/connect.mitacs.ca/core/lib/Drupal/Core/EventSubscriber/EarlyRenderingControllerWrapperSubscriber.php(97): Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->wrapControllerExecutionInRenderContext(Array, Array) #26 [internal function]: Drupal\Core\EventSubscriber\EarlyRenderingControllerWrapperSubscriber->Drupal\Core\EventSubscriber\{closure}() #27 /var/www/connect.mitacs.ca/vendor/symfony/http-kernel/HttpKernel.php(144): call_user_func_array(Object(Closure), Array) #28 /var/www/connect.mitacs.ca/vendor/symfony/http-kernel/HttpKernel.php(64): Symfony\Component\HttpKernel\HttpKernel->handleRaw(Object(Symfony\Component\HttpFoundation\Request), 1) #29 /var/www/connect.mitacs.ca/core/lib/Drupal/Core/StackMiddleware/Session.php(57): Symfony\Component\HttpKernel\HttpKernel->handle(Object(Symfony\Component\HttpFoundation\Request), 1, true) #30 /var/www/connect.mitacs.ca/core/lib/Drupal/Core/StackMiddleware/KernelPreHandle.php(47): Drupal\Core\StackMiddleware\Session->handle(Object(Symfony\Component\HttpFoundation\Request), 1, true) #31 /var/www/connect.mitacs.ca/core/modules/page_cache/src/StackMiddleware/PageCache.php(99): Drupal\Core\StackMiddleware\KernelPreHandle->handle(Object(Symfony\Component\HttpFoundation\Request), 1, true) #32 /var/www/connect.mitacs.ca/core/modules/page_cache/src/StackMiddleware/PageCache.php(78): Drupal\page_cache\StackMiddleware\PageCache->pass(Object(Symfony\Component\HttpFoundation\Request), 1, true) #33 /var/www/connect.mitacs.ca/core/lib/Drupal/Core/StackMiddleware/ReverseProxyMiddleware.php(47): Drupal\page_cache\StackMiddleware\PageCache->handle(Object(Symfony\Component\HttpFoundation\Request), 1, true) #34 /var/www/connect.mitacs.ca/core/lib/Drupal/Core/StackMiddleware/NegotiationMiddleware.php(50): Drupal\Core\StackMiddleware\ReverseProxyMiddleware->handle(Object(Symfony\Component\HttpFoundation\Request), 1, true) #35 /var/www/connect.mitacs.ca/vendor/stack/builder/src/Stack/StackedHttpKernel.php(23): Drupal\Core\StackMiddleware\NegotiationMiddleware->handle(Object(Symfony\Component\HttpFoundation\Request), 1, true) #36 /var/www/connect.mitacs.ca/core/lib/Drupal/Core/DrupalKernel.php(656): Stack\StackedHttpKernel->handle(Object(Symfony\Component\HttpFoundation\Request), 1, true) #37 /var/www/connect.mitacs.ca/index.php(19): Drupal\Core\DrupalKernel->handle(Object(Symfony\Component\HttpFoundation\Request)) #38 {main}.

Arg.. I really wish that error was displayed onscreen.

Here is the patch. I will probably do a hotfix release after DrupalCon.