Controls and Counters are missing for number of items less than (number of items per slide x number of slide).

This bug might arise with the fix of issue: https://www.drupal.org/node/2844052

Steps to Reproduce:
1) create a view slider with items per slide = 4 settings
2) add counter, pager, & controls in display with the options selected "Hide controls if there is only one slide" (for all)
3) now provide 7 results to the view
4) you will see there would be no controls, (or counters, pager) in display (check in frontend not in the views preview) which should be the case when results <=4
Now,
5) provide 8, 12, 16 (exact results multiple of 4 which is the number of items per slide)
6) the controls, counters, pager will be displayed

This means only when the number of items is exact multiple of set "items per slide" then only the controls, counters and pager will display otherwise not.

Members fund testing for the Drupal project. Drupal Association Learn more

Comments

nghai created an issue. See original summary.

nghai’s picture

Title: Controls and Counters are missing for number of items less than (number of items per slide x number of slide) » Controls and Counters are missing for the number of items less than (number of items per slide x number of slide)
nghai’s picture

nghai’s picture

It only happens when slide_count <2 but greater than 1 i.e. requires two slides to fit the total number of items.

Patch is attached. Please review it!

nghai’s picture

Assigned: Unassigned » nghai
Status: Active » Needs review
harivenuv’s picture

Hi nghai,

This patch is working thank you for the patch.

thank you,
Hari

harivenuv’s picture

Status: Needs review » Reviewed & tested by the community
NickWilde’s picture

Assigned: nghai » Unassigned
Status: Reviewed & tested by the community » Fixed

Makes sense, thanks for the patch, muchly appreciated!
sorry it took so long to get it committed.

  • NickWilde committed cdc0eba on 8.x-4.x authored by nghai
    Issue #2866310 by nghai: Controls and Counters are missing for the...
nghai’s picture

Thanks for accepting that patch!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.