From #2682949: Search API Autocomplete for Drupal 8,

We should add alter hooks, document them and remove all mentions of other hooks.

- hook_search_api_autocomplete_suggestions_alter()
- hook_search_api_autocomplete_suggester_alter()
- hook_search_api_autocomplete_type_alter()

CommentFileSizeAuthor
#6 2865821-6--document_and_test_hooks.patch11.78 KBdrunken monkey
#3 2865821-3--document_and_test_hooks.patch12.92 KBdrunken monkey

Comments

borisson_ created an issue. See original summary.

drunken monkey’s picture

drunken monkey
he/him
Primary language German
Location Vienna, Austria
commented
Issue tags: +beta blocker
drunken monkey’s picture

drunken monkey
he/him
Primary language German
Location Vienna, Austria
commented
Component: Code » General code
Status: Active » Needs review
StatusFileSize
new 2865821-3--document_and_test_hooks.patch12.92 KB

This should do it.
Did I miss anything?
Anyways, we can add more hooks at any point later, just need to make sure we've got the existing ones covered for now.

Status: Needs review » Needs work

The last submitted patch, 3: 2865821-3--document_and_test_hooks.patch, failed testing. View results

borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
commented

Does this patch need to be postponed on another issue or does it just need a reroll?

drunken monkey’s picture

drunken monkey
he/him
Primary language German
Location Vienna, Austria
commented
Status: Needs work » Needs review
StatusFileSize
new 2865821-6--document_and_test_hooks.patch11.78 KB

Ah, yes, it depends on the other three patches (or at least two of them), since I wanted to avoid having to rebase. Here it is in a form to apply to current HEAD.

Status: Needs review » Needs work

The last submitted patch, 6: 2865821-6--document_and_test_hooks.patch, failed testing. View results

drunken monkey’s picture

drunken monkey
he/him
Primary language German
Location Vienna, Austria
commented
Status: Needs work » Needs review

OK, now #3 works again, and also passes.

drunken monkey’s picture

drunken monkey
he/him
Primary language German
Location Vienna, Austria
commented
Component: General code » Framework

Status: Needs review » Needs work

The last submitted patch, 6: 2865821-6--document_and_test_hooks.patch, failed testing. View results

borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
commented
Status: Needs work » Reviewed & tested by the community

Looks great! No remarks here.

  • drunken monkey committed 8776104 on 8.x-1.x 
    Issue #2865821 by drunken monkey: Add tests and documentation for alter...
drunken monkey’s picture

drunken monkey
he/him
Primary language German
Location Vienna, Austria
commented
Status: Reviewed & tested by the community » Fixed

Good to hear, thanks!
Committed.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.