Closed (fixed)
Project:
Webform
Version:
8.x-5.x-dev
Component:
Code
Priority:
Normal
Category:
Feature request
Assigned:
Unassigned
Reporter:
Created:
29 Mar 2017 at 15:34 UTC
Updated:
16 Apr 2017 at 22:25 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
kclarkson commentedMultiple owners would also be good. I could see a scenario where its a group project and they want to add someone else.
Comment #4
jrockowitz commentedDrupal core does not support multiple owners but exposing the single owner is very easy to do.
Comment #8
jrockowitz commentedComment #9
jrockowitz commentedThe simplest solution is to add 'Submitted by' to the 'Notes' modal dialog. I don't expect a lot of administrators to be changing the submission's owner.
Comment #10
jrockowitz commentedHere is screenshot of the new field.
Comment #12
jrockowitz commentedComment #13
jrockowitz commentedComment #14
kclarkson commentedwhen clicking on my add note icon nothing happens. No pop up or anything.
Also any reason it can't be a field on the submission edit tab like similar to a node?
I feel like people are comfortable with that and I could see wanting to provide permissions to allow different roles to change the author.
Comment #15
jrockowitz commentedWhen the notes icon stops working, there is most likely a 500 error suppressing the modal dialog.
Try right clicking the notes icon and opening a new tab.
or go to the notes form via /admin/structure/webform/manage/WEBFORM_ID/submission/SID/notes
You can also go the 'Recent log messages' and see what error is being captured.
The 'Submitted by' field looked out of place on the main form. Most admins are not going to need to change the submission user.
Comment #16
kclarkson commentedJake,
When visiting the log link from within the webform I am receiving the following error:
Comment #17
jrockowitz commented@kaleem I am willing to bet you are running 8.2.x.
The \Drupal\webform\WebformSubmissionNotesForm::__construct method definition is different between 8.2.x and 8.3.x and the 'datetime.time' service is only in 8.3.x.
I can't find any change records about these API tweaks.
The attached patch should fix this issue. It contains a @todo to update the code once only 8.3.x is supported by the Webform module.
Comment #19
jrockowitz commentedI committed the patch. Please download and review the latest dev release.
Comment #20
jrockowitz commented