Once I have configured a view to use another report profile via Query settings, later deselecting this option doesn't revert to the default profile ID. This appears to be because of an isset() check that should be !empty() since deselecting the checkbox causes the value to be set to zero.

CommentFileSizeAuthor
#3 google_analytics_reports-undo_use_another_profile-2864873-3.patch623 bytesothermachines

Comments

othermachines created an issue. See original summary.

othermachines’s picture

othermachines commented
Issue summary: View changes

Correction.

othermachines’s picture

othermachines commented
Status: Active » Needs review
StatusFileSize
new google_analytics_reports-undo_use_another_profile-2864873-3.patch623 bytes
rajab natshah’s picture

rajab natshah
he/him
commented

Thank you othermachines for the fix
#2825785: Views query always queries google_analytics_reports_api_profiles_list()
Looks like that an optimization round is a must for this module

rajab natshah’s picture

rajab natshah
he/him
commented
Title: In view, can't unset "Use another reports profile" » Fix unset issue in views no letting [Use another reports profile] with empty default value

rajab natshah’s picture

rajab natshah
he/him
commented
Assigned: Unassigned » mohammed j. razem

Committed ... Thank you :)

rajab natshah’s picture

rajab natshah
he/him
commented
Assigned: mohammed j. razem » Unassigned
rajab natshah’s picture

rajab natshah
he/him
commented
Status: Needs review » Fixed
rajab natshah’s picture

rajab natshah
he/him
commented

#3102925: Add an automated testing for the [Google Analytics Reports] and API module

  • Having an optimization round over the code in the module.
  • Adding Drupal-ci automated testing for selected used testing cases
  • Then release an RC or Stable version

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.