email_confirm element allow as correct email like 'user@domain'

CommentFileSizeAuthor
#15 email_confirm_element-2864763-15.patch813 bytesjavivf
#10 email_confirm_element-2864763-10.patch1.74 KBjrockowitz
#8 email_confirm_element-2864763-8.patch2.28 KBjrockowitz
#2 email_confirm_element-2864763-2.patch715 bytesjavivf

Comments

javivf created an issue. See original summary.

javivf’s picture

javivf commented
Status: Active » Needs review
StatusFileSize
new email_confirm_element-2864763-2.patch715 bytes
javivf’s picture

javivf commented
Assigned: javivf » Unassigned

Status: Needs review » Needs work

The last submitted patch, 2: email_confirm_element-2864763-2.patch, failed testing.

jrockowitz’s picture

jrockowitz commented

This is HTML5 Email/core validation issue.

http://stackoverflow.com/questions/20573488/why-does-html5-form-validati...

I am not sure we should be fixing this. A better solution would be add #pattern support to the all email elements.

javivf’s picture

javivf commented

Ok, I see... ping me if you wants me for #pattern implementation
Thanks!

prashant.c’s picture

prashant.c
he/him
Primary language English
Location Dharamshala
commented

@javivf

I am not able to apply this patch.

Although i tried by manually adding the code in WebformEmailConfirm.php file from your patch but it is not solving the issue.

Apart from email_confirm field, email fields are also not validated for emails of type 'user@domain' and allowing the same, we need to fix the validation issue for all email type fields.

jrockowitz’s picture

jrockowitz commented
Status: Needs work » Needs review
StatusFileSize
new email_confirm_element-2864763-8.patch2.28 KB

I was surprised that #pattern was not set up for email elements. When I looked into the problem, I realized the Email element should be extending TextBase.

Please review the attached patch.

Status: Needs review » Needs work

The last submitted patch, 8: email_confirm_element-2864763-8.patch, failed testing.

jrockowitz’s picture

jrockowitz commented
Status: Needs work » Needs review
StatusFileSize
new email_confirm_element-2864763-10.patch1.74 KB

  • jrockowitz committed 808897a on 8.x-5.x 
    Issue #2864763 by jrockowitz, javivf, Prashant.c: email_confirm element...
jrockowitz’s picture

jrockowitz commented
Status: Needs review » Fixed

I tested the patch locally, fixed a minor issue, and committed it.

Please download the latest dev release to review.

javivf’s picture

javivf commented
Version: 8.x-5.0-beta9 » 8.x-5.x-dev
Status: Fixed » Needs work

Sorry but I tried with webform/tests/modules/webform_test/config/install/webform.webform.test_element_email.yml with a correct email at Email confirm pattern field/Confirm email field and I got this error:

Email confirm pattern field is not in the right format.
Confirm email field is not in the right format.
jrockowitz’s picture

jrockowitz commented

@javivf Please check your pattern using a simple textfield. The #pattern validation is being handled by Core, I am not sure this webform issue.

javivf’s picture

javivf commented
StatusFileSize
new email_confirm_element-2864763-15.patch813 bytes

@jrockowitz I agree, the problem is with pattern, please review if the patch make sense for you. Thanks!

javivf’s picture

javivf commented
Status: Needs work » Needs review

  • jrockowitz committed dde2673 on 8.x-5.x authored by javivf 
    Issue #2864763 by javivf, jrockowitz, Prashant.c: email_confirm element...
jrockowitz’s picture

jrockowitz commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.