Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.email_confirm element allow as correct email like 'user@domain'
| Comment | File | Size | Author |
|---|---|---|---|
| #15 | email_confirm_element-2864763-15.patch | 813 bytes | javivf |
| |||
| #10 | email_confirm_element-2864763-10.patch | 1.74 KB | jrockowitz |
| #8 | email_confirm_element-2864763-8.patch | 2.28 KB | jrockowitz |
| |||
| #2 | email_confirm_element-2864763-2.patch | 715 bytes | javivf |
Comments
Comment #2
javivf CreditAttribution: javivf commentedComment #3
javivf CreditAttribution: javivf commentedComment #5
jrockowitz CreditAttribution: jrockowitz as a volunteer and at The Big Blue House commentedThis is HTML5 Email/core validation issue.
http://stackoverflow.com/questions/20573488/why-does-html5-form-validati...
I am not sure we should be fixing this. A better solution would be add #pattern support to the all email elements.
Comment #6
javivf CreditAttribution: javivf commentedOk, I see... ping me if you wants me for #pattern implementation
Thanks!
Comment #7
Prashant.c@javivf
I am not able to apply this patch.
Although i tried by manually adding the code in
WebformEmailConfirm.phpfile from your patch but it is not solving the issue.Apart from email_confirm field, email fields are also not validated for emails of type 'user@domain' and allowing the same, we need to fix the validation issue for all email type fields.
Comment #8
jrockowitz CreditAttribution: jrockowitz as a volunteer and at The Big Blue House commentedI was surprised that #pattern was not set up for email elements. When I looked into the problem, I realized the Email element should be extending TextBase.
Please review the attached patch.
Comment #10
jrockowitz CreditAttribution: jrockowitz as a volunteer and at The Big Blue House commentedComment #12
jrockowitz CreditAttribution: jrockowitz as a volunteer and at The Big Blue House commentedI tested the patch locally, fixed a minor issue, and committed it.
Please download the latest dev release to review.
Comment #13
javivf CreditAttribution: javivf commentedSorry but I tried with webform/tests/modules/webform_test/config/install/webform.webform.test_element_email.yml with a correct email at Email confirm pattern field/Confirm email field and I got this error:
Comment #14
jrockowitz CreditAttribution: jrockowitz as a volunteer and at The Big Blue House commented@javivf Please check your pattern using a simple textfield. The #pattern validation is being handled by Core, I am not sure this webform issue.
Comment #15
javivf CreditAttribution: javivf commented@jrockowitz I agree, the problem is with pattern, please review if the patch make sense for you. Thanks!
Comment #16
javivf CreditAttribution: javivf commentedComment #18
jrockowitz CreditAttribution: jrockowitz as a volunteer and at The Big Blue House commented