Comments

sandeepscs created an issue. See original summary.

sandeepscs’s picture

Assigned: sandeepscs » Unassigned
Issue summary: View changes
Status: Active » Needs review
StatusFileSize
new3.24 KB

Please find attached file for patch.

sharique’s picture

+++ b/core/tests/README.md
@@ -18,7 +18,7 @@ Note: functional tests have to be invoked with a user in the same group as the
diff --git a/sites/example.sites.php b/sites/example.sites.php

Why this file is deleted?

renatog’s picture

Assigned: Unassigned » renatog
Status: Needs review » Active

Work in progress.

renatog’s picture

Assigned: renatog » Unassigned
Status: Active » Needs review
StatusFileSize
new752 bytes

Hi people.

Thanks for your contribution @sandeepscs.

I create a fix with a patch with example.sites.php file included.

Patch it's in attachment.

Good Work and Good Week.

Regards.

rodrigoac’s picture

Status: Needs review » Reviewed & tested by the community
StatusFileSize
new9.5 KB

Hello,

Thanks for correct this !

renatog’s picture

Thanks for your review @rodrigoac.

Hugs.

wim leers’s picture

Priority: Normal » Minor
cilefen’s picture

Status: Reviewed & tested by the community » Needs work
+++ b/core/tests/README.md
@@ -18,7 +18,7 @@ Note: functional tests have to be invoked with a user in the same group as the
-To develop locally, a straigtforward - but also less secure - approach is to run
+To develop locally, a straightforward - but also less secure - approach is to run

This line exceeds 80 columns.

renatog’s picture

Status: Needs work » Needs review
StatusFileSize
new752 bytes

N/A

Status: Needs review » Needs work

The last submitted patch, 10: drupal-spelling_mistake-2864690-10.patch, failed testing.

renatog’s picture

Status: Needs work » Needs review
StatusFileSize
new915 bytes

It's true. Good catch.

Thank you very much for your review @cilefen.

New patch it's in attachment.

Good Work and Good Week.

Regards.

anarthul’s picture

Status: Needs review » Reviewed & tested by the community
StatusFileSize
new206.66 KB

Tested and it works this time. Submitted a review screenshot

amit.drupal’s picture

Good Work..
Patch is working.

renatog’s picture

Hi! Good Morning.

Thank you very much for yours reviews guys.

Good Work.

Hugs.

lauriii’s picture

Status: Reviewed & tested by the community » Needs review

Thank you for reviewing this issue!

The automated testing infrastructure tells us whether the patch applies, so we do not need people to review that. It is also not sufficient criteria for the issue to be marked "Reviewed and Tested by the Community".

What we do need people to review is whether the issue has a correct scope, whether it passes the core gates, whether the solution completely fixes the problem without introducing other problems, and whether it's the best solution we can come up with. See the patch review guide for more information.

When you do post a review, be sure to describe what you reviewed and how. This helps other reviewers understand why you considered the issue RTBC (and is considered for issue credit).

sahilsharma011’s picture

StatusFileSize
new70.97 KB
new73.19 KB

@renatog patch mentioned in #12 is working. It fixes the spelling mistake.

sissonen’s picture

Patch in #12 works as designed. Scope is alright and core gates are passed. This is the best solution.

sissonen’s picture

Status: Needs review » Reviewed & tested by the community
cilefen’s picture

Title: Spelling Mistake » Fix typos in core README files
Related issues: +#2829185: Fix spelling errors in Drupal core comments

Dear everyone who reviewed this issue:

Screenshots of code are never part of a review. Screenshots of UI changes caused by code changes are sometimes appropriate, and sometimes asked for. I checked every README file, because that is a better scope for this issue. I did it this way:

find core/ -name README.* -exec aspell -c {} \;

In fact, this one is the only mistype I could find, and this is appropriately scoped now.

  • cilefen committed 4a892d8 on 8.4.x
    Issue #2864690 by renatog, sandeepscs, cilefen: Fix typos in core README...

  • cilefen committed d1de3df on 8.3.x
    Issue #2864690 by renatog, sandeepscs, cilefen: Fix typos in core README...
cilefen’s picture

Status: Reviewed & tested by the community » Fixed

Committed 4a892d8 and pushed to 8.4.x. Cherry-picked as d1de3df and pushed to 8.3.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.