Closed (fixed)
Project:
Drupal core
Version:
8.4.x-dev
Component:
other
Priority:
Minor
Category:
Task
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
28 Mar 2017 at 12:46 UTC
Updated:
22 Apr 2017 at 20:25 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
sandeepscs commentedPlease find attached file for patch.
Comment #3
sharique commentedWhy this file is deleted?
Comment #4
renatog commentedWork in progress.
Comment #5
renatog commentedHi people.
Thanks for your contribution @sandeepscs.
I create a fix with a patch with example.sites.php file included.
Patch it's in attachment.
Good Work and Good Week.
Regards.
Comment #6
rodrigoac commentedHello,
Thanks for correct this !
Comment #7
renatog commentedThanks for your review @rodrigoac.
Hugs.
Comment #8
wim leersComment #9
cilefen commentedThis line exceeds 80 columns.
Comment #10
renatog commentedN/A
Comment #12
renatog commentedIt's true. Good catch.
Thank you very much for your review @cilefen.
New patch it's in attachment.
Good Work and Good Week.
Regards.
Comment #13
anarthul commentedTested and it works this time. Submitted a review screenshot
Comment #14
amit.drupal commentedGood Work..
Patch is working.
Comment #15
renatog commentedHi! Good Morning.
Thank you very much for yours reviews guys.
Good Work.
Hugs.
Comment #16
lauriiiThank you for reviewing this issue!
The automated testing infrastructure tells us whether the patch applies, so we do not need people to review that. It is also not sufficient criteria for the issue to be marked "Reviewed and Tested by the Community".
What we do need people to review is whether the issue has a correct scope, whether it passes the core gates, whether the solution completely fixes the problem without introducing other problems, and whether it's the best solution we can come up with. See the patch review guide for more information.
When you do post a review, be sure to describe what you reviewed and how. This helps other reviewers understand why you considered the issue RTBC (and is considered for issue credit).
Comment #17
sahilsharma011 commented@renatog patch mentioned in #12 is working. It fixes the spelling mistake.
Comment #18
sissonen commentedPatch in #12 works as designed. Scope is alright and core gates are passed. This is the best solution.
Comment #19
sissonen commentedComment #20
cilefen commentedDear everyone who reviewed this issue:
Screenshots of code are never part of a review. Screenshots of UI changes caused by code changes are sometimes appropriate, and sometimes asked for. I checked every README file, because that is a better scope for this issue. I did it this way:
find core/ -name README.* -exec aspell -c {} \;In fact, this one is the only mistype I could find, and this is appropriately scoped now.
Comment #23
cilefen commentedCommitted 4a892d8 and pushed to 8.4.x. Cherry-picked as d1de3df and pushed to 8.3.x. Thanks!