Hi,

There is no configure attribute in graphapi.info.yml so "Configure" link are not being shown in modules list.

CommentFileSizeAuthor
#13 graphapi-rework_configure_link_attribute-2864447-13-8x.patch330 bytesmgoncalves
#7 Graph API test.png13.58 KBmgoncalves
#6 missing_configure-2864447-6.patch341 bytesdhruveshdtripathi
#3 error page.PNG28.82 KBAanal.addweb
#3 after patch-Graph Api.png11.47 KBAanal.addweb
#3 before patch-Graph Api.PNG10.37 KBAanal.addweb
#2 graphapi-configure_attribute-2864447-2-8x.patch326 bytesmgoncalves

Comments

mgoncalves created an issue. See original summary.

mgoncalves’s picture

mgoncalves commented
Assigned: mgoncalves » Unassigned
Status: Active » Needs review
StatusFileSize
new graphapi-configure_attribute-2864447-2-8x.patch326 bytes
Aanal.addweb’s picture

Aanal.addweb commented
Status: Needs review » Needs work
StatusFileSize
new before patch-Graph Api.PNG10.37 KB
new after patch-Graph Api.png11.47 KB
new error page.PNG28.82 KB

@mgoncalves, Thanks for the patch but configure link is showing fatal error & also there is no link available on configuration page.

dhruveshdtripathi’s picture

dhruveshdtripathi commented
Assigned: Unassigned » dhruveshdtripathi

Working on this

mgoncalves’s picture

mgoncalves commented

Hello @dhwani.addweb

Yes, This error is reported in another bug. #2143593 Menu item to /admin/config/system/graphapi has no visible entry on /admin/config

I submitted a patch to fix this error...

@dhruveshdtripathi
Take a look on the bug that I said before you continue.

Thank you guys

dhruveshdtripathi’s picture

dhruveshdtripathi commented
Assigned: dhruveshdtripathi » Unassigned
Status: Needs work » Needs review
StatusFileSize
new missing_configure-2864447-6.patch341 bytes

Hi @mgoncalves

I looked at the other issue as well, the other issue is different actually. In info.yml file we add configure attribute which will create a configure link on module listing page and the link take us to settings of the module. So I found configuration form link from routing file and added in info.yml with configure attribute.

mgoncalves’s picture

mgoncalves commented
StatusFileSize
new Graph API test.png13.58 KB

Hello @dhruveshdtripathi

It's wrong.
In the configuration page you should see.
Configuration Page

Thank you

dhruveshdtripathi’s picture

dhruveshdtripathi commented

If so then your patch is OK and that won't give error after the other issue you mention will be committed.

Aanal.addweb’s picture

Aanal.addweb commented
Status: Needs review » Reviewed & tested by the community

@mgoncalves & Dhruvesh, i checked your patch with the combination of #6 & the patch attached in #2143593 Menu item to /admin/config/system/graphapi has no visible entry on /admin/config & it works well for me.
let me know if i'm wrong.

mgoncalves’s picture

mgoncalves commented

Hi @dhwani.addweb

The right commit is #2.
Doesn't make sense hide "Graph API Format".

You must see your module as mentioned at #7.

Thank you to test.

  • dhruveshdtripathi authored 4027814 on 8.x-1.x 
    Issue #2864447 by mgoncalves, dhruveshdtripathi, dhwani.addweb: Missing...
clemens.tolboom’s picture

clemens.tolboom
Primary language Dutch
Location Groningen, 🇳🇱/🇪🇺
commented
Status: Reviewed & tested by the community » Fixed
mgoncalves’s picture

mgoncalves commented
Status: Fixed » Needs review
StatusFileSize
new graphapi-rework_configure_link_attribute-2864447-13-8x.patch330 bytes

Hello Guys,

As said before. The configuration point at graphapi.settings is wrong, if we made it, we are hiding the option "Graph API Formats".
We should see all options available to configure this module. It means the right configuration is graphapi.overview.
Following the configuration above, you would be able to see the image attached on the #7 commentary.

Remember that, this page has a bug. You can apply the patch #2143593 Menu item to /admin/config/system/graphapi has no visible entry on /admin/config

Please, commit the right configuration.

Thanks

dhruveshdtripathi’s picture

dhruveshdtripathi commented
Status: Needs review » Reviewed & tested by the community

Patch applied cleanly. Now the configure link redirects to /admin/config/system/graphapi

clemens.tolboom’s picture

clemens.tolboom
Primary language Dutch
Location Groningen, 🇳🇱/🇪🇺
commented

Hmmm ... this module needs some love / maintainers.

@mgoncalves

Testing #13 gives me a controller error (non existing)

Visiting http://drupal.d8/admin/config/system/graphapi/settings works.

  • joachim committed 00897e0 on 2.0.x authored by mgoncalves 
    Issue #2864447 by mgoncalves, dhruveshdtripathi: Fixed configure...
joachim’s picture

joachim commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.