Follow-up to #2863425: Anonymous view own submission

Problem/Motivation

Anonymous submissions can be track via $_SESSION. This will user limits to be tracked and saved anonymous submissions converted to authenticated submission after a user logs in.

Proposed resolution

Add support for 'view own submission' permission and anonymous submissions.

Remaining tasks

  • Never convert confidential anonymous submissions to authenticated submissions
  • Add 'view own permission' to webform.permissions.yml.
  • Remove comment about 'view own permission''
  • Add 'Anonymous' role to Webform Access tab view/update/delete own.
  • Add $check_session parameter to allow WebformSubmission query methods. Default to FALSE. This will help to clearing indicate when $_SESSION is meant to be used.
  • Add WebformSubmissionStorage::setQueryConditions()
  • Update \Drupal\webform\Entity\Webform::checkAccessRules
  • Update WebformSubmissionStorage::setAnonymousSubmission
  • Refactor account based queries to $_SESSION
  • WebformSubmissionStorage::getTerminusSubmission
  • WebformSubmissionStorage::getSiblingSubmission
  • WebformSubmissionStorage::getMaxSubmissionId
  • WebformSubmissionStorage::getTotal
  • Update 'session' context to check submission 'view own' access.
  • Add WebformTestBase::updateAnonymousUser
  • Check \Drupal\webform\WebformSubmissionForm::checkUserLimit

Tests

  • Anonymous user limits based $_SESSION.
  • Anonymous user view previous.

New Premissions

  • 'view own webform submission':
  • 'edit any webform submission':
  • 'edit own webform submission':
  • 'delete any webform submission':
  • 'delete own webform submission':

API changes

Session tracking will be added to the WebformSubmissionManager.

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

jrockowitz created an issue. See original summary.

  • jrockowitz committed f8c0114 on 2863809-anonymous-view-own-submission
    Issue #2863809: Add support for 'view own submission' permission and...
jrockowitz’s picture

Issue summary: View changes

  • jrockowitz committed 7d3aed0 on 2863809-anonymous-view-own-submission
    Issue #2863809: Add support for 'view own submission' permission and...

  • jrockowitz committed 55b2d3c on 2863809-anonymous-view-own-submission
    Issue #2863809: Add support for 'view own submission' permission and...

  • jrockowitz committed 952e2c1 on 2863809-anonymous-view-own-submission
    Issue #2863809: Add support for 'view own submission' permission and...

  • jrockowitz committed 2766e4b on 2863809-anonymous-view-own-submission
    Issue #2863809: Add support for 'view own submission' permission and...
jrockowitz’s picture

Status: Active » Needs review
FileSize
60.21 KB

Status: Needs review » Needs work

The last submitted patch, 8: add_support_for_view-2863809-8.patch, failed testing.

  • jrockowitz committed 08889c4 on 2863809-anonymous-view-own-submission
    Issue #2863809: Add support for 'view own submission' permission and...
jrockowitz’s picture

Status: Needs work » Needs review
FileSize
60.85 KB

  • jrockowitz committed 07ddbe1 on 2863809-anonymous-view-own-submission
    Issue #2863809 by jrockowitz: Add support for 'view own submission'...

  • jrockowitz committed 3d21fdb on 8.x-5.x
    Issue #2863809 by jrockowitz: Add support for 'view own submission'...

  • jrockowitz committed 8fde0ae on 8.x-5.x
    Issue #2863809 by jrockowitz: Add support for 'view own submission'...
jrockowitz’s picture

Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.