Search API dev, Facets dev, Core dev.

Core date facet causes an exception as no plugin available (see patch).
Date facet granularity settings don't change anything.
Requires tests.

CommentFileSizeAuthor
#7 core_date_facet-2862999-7.patch2.57 KBborisson_
#7 interdiff-2862999.txt789 bytesborisson_
#5 core_date_facet-2862999-5.patch2.12 KBborisson_
#5 interdiff-2862999.txt1.45 KBborisson_
#2 2862999-01.core_date_facet.patch699 bytesekes

Comments

ekes created an issue. See original summary.

ekes’s picture

ekes commented
StatusFileSize
new 2862999-01.core_date_facet.patch699 bytes

Fixes the plug-in exception.

borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
commented
Status: Active » Needs review
Issue tags: +Needs tests

Let's see what breaks when we run tests.

Status: Needs review » Needs work

The last submitted patch, 2: 2862999-01.core_date_facet.patch, failed testing.

borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
commented
Status: Needs work » Needs review
StatusFileSize
new interdiff-2862999.txt1.45 KB
new core_date_facet-2862999-5.patch2.12 KB

Hah, it looks like the core search tests weren't actually running, that's a fun discovery... :(

In any case, this makes the tests run again. Let's see how much we broke for those tests.

Status: Needs review » Needs work

The last submitted patch, 5: core_date_facet-2862999-5.patch, failed testing. View results

borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
commented
Status: Needs work » Needs review
StatusFileSize
new interdiff-2862999.txt789 bytes
new core_date_facet-2862999-7.patch2.57 KB

Tests should be green now.

borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
commented
Status: Needs review » Reviewed & tested by the community
Issue tags: -Needs tests

I think this should be fine, we can always open more specific followups, thanks @ekes!

borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
commented
Status: Reviewed & tested by the community » Fixed

Committed this, followups to improve date handling are in #2896229: move date handling to a processor, so date facets can use existing widgets. At least partly.

  • borisson_ committed 3773e7a on 8.x-1.x 
    Issue #2862999 by borisson_, ekes: Core date facet

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.