This will be a start to #2762997: Expand promotion compatibility settings.

Let's start implementing discount compatibility by implementing the basic

  • Any promotion
  • Not with any other promotions

CommentFileSizeAuthor
#4 prevent_a_promotion-2862945-4.patch12.9 KBmglaman
#2 prevent_a_promotion-2862945-2.patch11.28 KBmglaman
Add_order_discount_commerce_discount___Site-Install.png37.3 KBmglaman

Comments

mglaman created an issue. See original summary.

mglaman’s picture

mglaman
Primary language English
Location WI, USA
commented
Status: Active » Needs work
StatusFileSize
new prevent_a_promotion-2862945-2.patch11.28 KB

https://github.com/drupalcommerce/commerce/pull/687

Needs an update call to ensure new field exists.

mglaman’s picture

mglaman
Primary language English
Location WI, USA
commented
Status: Needs work » Needs review

Added post update to PR

mglaman’s picture

mglaman
Primary language English
Location WI, USA
commented
StatusFileSize
new prevent_a_promotion-2862945-4.patch12.9 KB

Uploading patch for client build process.

mglaman’s picture

mglaman
Primary language English
Location WI, USA
commented
Status: Needs review » Needs work

This passes locally with PHPUnit but not with run-tests.sh locally or travis.

mglaman’s picture

mglaman
Primary language English
Location WI, USA
commented
Status: Needs work » Needs review
Related issues: +#2863860: Promotions need a sort order

This works when removing refresh check, due to missing sort order. This is blocked by #2863860: Promotions need a sort order.

  • mglaman committed 9bddff6 on 8.x-2.x 
    Issue #2862945 by mglaman: Prevent a promotion from applying if other...
mglaman’s picture

mglaman
Primary language English
Location WI, USA
commented
Status: Needs review » Fixed

We have basic compatibility!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.