In order to properly execute #2762997: Expand promotion compatibility settings, we need some kind of sort order that defines how the promotion storage loads them. Otherwise they will load in a random fashion and not bring much sense to the compatibility settings.

Comments

mglaman created an issue. See original summary.

mglaman’s picture

mglaman
Primary language English
Location WI, USA
commented
Assigned: Unassigned » mglaman
bojanz’s picture

bojanz commented

We can copy the weight code from shipping methods

mglaman’s picture

mglaman
Primary language English
Location WI, USA
commented

PR is up https://github.com/drupalcommerce/commerce/pull/696

I wonder if there's a better term. I liked the thought of using Priority instead of sort order. Either way code is ready. MIssing update hook and terminology bike shed

mglaman’s picture

mglaman
Primary language English
Location WI, USA
commented
Status: Active » Needs review

  • bojanz committed 1c07f4f on 8.x-2.x authored by mglaman 
    Issue #2863860 by mglaman: Promotions need a sort order (#696)
bojanz’s picture

bojanz commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.