Hi,

Problem

Actually, I created a webform on a multilingue project which contains a component using Term select.

This component is linked to a vocabulary, some of terms are translated.

When i printed my webform, I saw that in list terms options, terms name are printed in the original language but not with the current language of the page.

Proposed resolution

Before the term name is get:

  • Check if the term is translatable and has a translation to get it
  • Use the name of the translatable term instead of the original name.

Please see the attached patch in my next comment.

CommentFileSizeAuthor
#8 print_term_select-2862845-8.patch2.31 KBjrockowitz
#6 webform-print-term-select-reference-items-translated-2862845-6.patch2.3 KBtsymi
#4 webform-print-term-select-reference-items-translated-2862845-4.patch2.3 KBtsymi
#2 webform-print-term-select-reference-items-translated-2862845-1.patch2.3 KBtsymi

Comments

Tsymi created an issue. See original summary.

tsymi’s picture

tsymi commented
Status: Active » Needs review
StatusFileSize
new webform-print-term-select-reference-items-translated-2862845-1.patch2.3 KB

Status: Needs review » Needs work

The last submitted patch, 2: webform-print-term-select-reference-items-translated-2862845-1.patch, failed testing.

tsymi’s picture

tsymi commented
Status: Needs work » Needs review
StatusFileSize
new webform-print-term-select-reference-items-translated-2862845-4.patch2.3 KB

Sorry, please find my patch fixed.

Status: Needs review » Needs work

The last submitted patch, 4: webform-print-term-select-reference-items-translated-2862845-4.patch, failed testing.

tsymi’s picture

tsymi commented
Status: Needs work » Needs review
StatusFileSize
new webform-print-term-select-reference-items-translated-2862845-6.patch2.3 KB

Patch attached with another fix.

jrockowitz’s picture

jrockowitz commented

The only tweak that I am going to make is change...

        if ($item->isTranslatable()) {
          if ($item->hasTranslation($language)) {
            $item = $item->getTranslation($language);
          }
          else {
            continue;
          }
        }

...to...

        if ($item->isTranslatable() && $item->hasTranslation($language)) {
            $item = $item->getTranslation($language);
        }

...because as general rule, it is okay to let the source language bleed through when there is no translation. If a vocabulary had no translated terms the menu would be empty or if a parent term is missing a translation, the menu would appear broken.

jrockowitz’s picture

jrockowitz commented
StatusFileSize
new print_term_select-2862845-8.patch2.31 KB

  • jrockowitz committed 31ff1e1 on 8.x-5.x 
    Issue #2862845 by Tsymi, jrockowitz: Print term select reference...
jrockowitz’s picture

jrockowitz commented
Status: Needs review » Fixed

@Tsymi thanks for the patch.

I committed the latest patch. Please download and review the latest dev release. Don't hesitate to post more tweaks and reopen this ticket if needed.

tsymi’s picture

tsymi commented

Hi jrockowitz,

Thanks for your return :)

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.