Closed (fixed)
Project:
Accelerated Mobile Pages (AMP)
Version:
7.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
20 Mar 2017 at 14:02 UTC
Updated:
25 May 2017 at 15:54 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
marcelovaniFixes:
1 - Enable field_ui
2 - Created a protected variable for admin_user and did the login on setUp()
3 - Set necessary permissions for Admin user:
ps: The test won't run automatically because it's turned off on the module's project page. Hope we can turn that back on now.
Comment #3
marcelovaniOne more change needed
$edit is being overriden on the next line in
Fix:
Comment #4
marcelovaniComment #5
marcelovaniComment #6
marcelovaniRe-rolled patch
Comment #8
marcelovaniFound a possible solution for the autoloader, without using composer_manager
https://www.drupal.org/node/2597778#comment-11838528
I also created a helper module just to add the include
Comment #9
marcelovaniComment #11
marcelovaniDebugging Drupal CI
Comment #13
marcelovaniComment #15
marcelovaniTrying to figure out what's being outputted on the page
Comment #16
marcelovaniComment #18
marcelovaniFound it: Clean urls to blame
https://www.drupal.org/pift-ci-job/654426
Comment #19
marcelovaniComment #21
marcelovaniOf course, when Clean urls are disabled, the first argument will have ? and the amp argument will have &
Comment #23
marcelovaniAgain
Comment #24
marcelovaniFinally I got this working, its really hard to reproduce locally that happens on Drupal CI.
The fact that Clean urls are disabled is something to keep in mind when writing tests that should work with this setting on/off. I even thought about changing the setting with variable_set and test both cases, but maybe its not really necessary.
The other problem was the dependency on composer_manager, since its not a required module, it doesn't get checked out during the build. I found an acceptable workaround by doing an include to the autoloader generated by composer during the build.
Also, I put this on a dedicated helper module that gets enabled during testing run time only.
One last thing to address, but in another ticket perhaps, is that the themes are not being downloaded for the same reasons.
Comment #26
mtiftLooks good to me. Thanks for getting this working, marcelovani!
Committed to 7.x-1.x