Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Hi people. How are you?
Congrats on the project. It's is very cool.
We update de readme for new template: https://www.drupal.org/docs/develop/documenting-your-project/readme-template
Comment | File | Size | Author |
---|---|---|---|
#18 | interdiff-16-18.txt | 1.91 KB | neel24 |
#18 | flag-updated-readme-2862099-18.patch | 5.05 KB | neel24 |
#16 | interdiff-15-16.txt | 2.6 KB | neerajpandey |
#16 | flag-updated-readme-2862099-16.patch | 4.83 KB | neerajpandey |
#15 | flag-updated-readme-2862099-15.patch | 4.33 KB | neel24 |
|
Comments
Comment #2
renatogThe patch it's in attachment.
Good Work and Good Week.
Regards.
Comment #3
krina.addweb CreditAttribution: krina.addweb at AddWeb Solution Pvt. Ltd. commented@renatog, thanks for the patch it works well & following are the issues which were founded from Readme patch.
1)
Change Administer -> Modules (/admin/modules) to Administration -> Modules
2)
Change Administer -> Structure -> Flags (/admin/modules) to Administration -> Structure -> Flags
3) Current maintainers: Add "https://www.drupal.org/u/fago" fago as maintainer
Comment #4
dhruveshdtripathi CreditAttribution: dhruveshdtripathi at DevsAdda for OpenSense Labs commentedThank you @krina.addweb for suggesting changes. Working on it.
Comment #5
dhruveshdtripathi CreditAttribution: dhruveshdtripathi at DevsAdda for OpenSense Labs commentedMade changes according to comment #3. Removed whitespace which was giving a warning while applying the last patch.
Comment #6
dhruveshdtripathi CreditAttribution: dhruveshdtripathi at DevsAdda for OpenSense Labs commentedComment #7
renatogThank you @krinaaddweb for your review and @dhruveshdtripathi for your contribution.
Works Good for me. +RTBC
Regards.
Comment #8
joachim CreditAttribution: joachim commentedThanks everyone for working on this! (And thanks for making me aware of the README standard -- I wasn't aware of it.)
However, work should be done on the 8.x-4.x branch first and then backported.
Also, a few small nitpicks:
These lines can be removed, per the README Template docs.
This should go under requirements, surely?
The docs don't mention the need for this, so let's remove it. d.org adds the licence file anyway.
Comment #9
dhruveshdtripathi CreditAttribution: dhruveshdtripathi at DevsAdda for OpenSense Labs commentedWorking on it
Comment #10
dhruveshdtripathi CreditAttribution: dhruveshdtripathi at DevsAdda for OpenSense Labs commentedCreated a patch for 8.x-4.x branch. Made few changes according to standards.
Comment #11
joachim CreditAttribution: joachim commentedLooking good, thanks!
The section on installation still needs to be changed to the standard form suggested in the template.
Comment #12
dhruveshdtripathi CreditAttribution: dhruveshdtripathi at DevsAdda for OpenSense Labs commentedYes, installation section still needs to be changed to the standard form. Working on it.
Thanks!
Comment #13
dhruveshdtripathi CreditAttribution: dhruveshdtripathi at DevsAdda for OpenSense Labs commentedMade changes in INSTALLATION section according to template.
Following points are taken care in the patch:
- Bullets denoted by asterisks (*) with hanging indents.
- Numbered lists indented 4 spaces.
Thank you!
Comment #14
joachim CreditAttribution: joachim commented> Made changes in INSTALLATION section according to template.
That change seems to have been missed off.
The template has this:
The latest patch still has more detail than is needed.
Comment #15
neel24 CreditAttribution: neel24 at Google Code-In commentedOk so I've created a new patch which applies the readme, following the readme template: https://www.drupal.org/docs/develop/documenting-your-project/readme-temp...
Comment #16
neerajpandey CreditAttribution: neerajpandey at Google Code-In commented#15 looks fine. It just needs some spacing edits and support request section. Adding a patch and interdiff for the same.
Comment #17
alonaoneill CreditAttribution: alonaoneill at Hook 42 commentedAdd "To submit bug reports and feature suggestions, or to track changes" part here
Make it numbered list?
I would remove those empty lines
Comment #18
neel24 CreditAttribution: neel24 at Google Code-In commentedAlright, so I've created a new patch based on the one in #16 and applied the changes mentioned in #17. I've also attached an interdiff.
Comment #19
alonaoneill CreditAttribution: alonaoneill at Hook 42 commentedReviewed the patch for spelling and grammar. Formatting aligns to Drupal documentation standards. Everything looks good. Patch applied.
Marking as RTBCed.
Thank you for working on the module!
Comment #20
BerdirAdded myself as a maintainer and committed.