Problem/Motivation

Running tests using the search_api results in test fails.

PHP Fatal error:  Cannot declare class Drupal\Tests\search_api_db\IntegrationTest, because the name is already in use in /Volumes/devdisk/dev/sites/drupal8alt.dev/modules/search_api/modules/search_api_db/tests/src/FunctionalJavascript/IntegrationTest.php on line 13

Furthermore the modules form has changed in 8.3.x which means we need to make the test version aware.

Proposed resolution

Fix the tests

Remaining tasks

User interface changes

None

API changes

None

Data model changes

None

CommentFileSizeAuthor
#2 2861587-2.patch2.55 KBalexpott

Comments

alexpott created an issue. See original summary.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Active » Needs review
StatusFileSize
new 2861587-2.patch2.55 KB
borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
commented
Status: Needs review » Reviewed & tested by the community

I wonder why the testbots didn't break on this before, since we were already testing on 8.4.x. Possibly because of the wrong namespace and the testbot not picking those up (the last branch test has 332 tests, this one has 334 so that would be possible)? Anyway, these changes look solid, thanks Alex!

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented

@borisson_ yep that's totally why - the tests are not being discovered :)

drunken monkey’s picture

drunken monkey
he/him
Primary language German
Location Vienna, Austria
commented
Status: Reviewed & tested by the community » Fixed

Oh, wow, the namespaces were really stupid mistakes. Thanks a lot for spotting those, and of course also thanks for fixing the fails this uncovered!
Committed your patch. Thanks again!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.