Decompose Importer::importContent() method

That's looks great, but I'd prefer to split the manager first

+++ b/src/DefaultContentManager.php
@@ -234,6 +177,120 @@ class DefaultContentManager implements DefaultContentManagerInterface {
+  ¶
...
+  }    ¶

nits, trailing whitespaces

There's now single \Drupal\default_content\ImporterInterface::importContent()

I like the way this is going. Here's some other thoughts:

• I think we can get rid of the some of the static properties too so we don't need a reset.
• I think the importContent should be at the top - its the main business of the class
• I think we can do an early return in importContent if there is no folder
• Exceptions shouldn't be using a markup object - sprintf is good.
• The whole reflection dance to work out what's config / content entities is not required.

Here's an interdiff of the changes I would apply to #19

This also passes tests - you can run them locally there's only 2!

@aaronbauman - fyi you can just apply the interdiff in #21 on top of your patch in #19 to see how it looks locally.

+++ b/src/Importer.php
@@ -112,6 +120,122 @@ class Importer implements ImporterInterface {
+    $files = $this->scanner()->scan($folder . '/' . $entity_type->id());
+    // Default content uses drupal.org as domain.
+    // @todo Make this use a uri like default-content:.
+    $this->linkManager->setLinkDomain(static::LINK_DOMAIN);

Both of these are fixed in the interdiff on #21. Should be $this->scanner->scan() and $this->linkManager->setLinkDomain($this->linkDomain).

@aaronbauman you can just run the default_content group. It's easiest from the command line. Something like:

sudo -u USER_RUNNING_APACHE php ./core/scripts/run-tests.sh --color --non-html --url http://YOU_LOCAL_URL/ --verbose default_content

You need to replace USER_RUNNING_APACHE and http://YOU_LOCAL_URL/ with whatever is right for you.

1. +++ b/src/Importer.php
   @@ -118,85 +115,157 @@ class Importer implements ImporterInterface {
   +      // There's no default to import.
   

   There's no default content to import.

2. +++ b/src/Importer.php
   @@ -118,85 +115,157 @@ class Importer implements ImporterInterface {
   -      $this->eventDispatcher->dispatch(DefaultContentEvents::IMPORT, new ImportEvent($created, $module));
   -      $this->accountSwitcher->switchBack();
   

   This is a really good improvement since the event listeners definitely should not be invoked with the account we switch to.

Looking good, thanks

#31 could be fixed on commit

I've recently created the 2.0.x branch, see the project page on all the improvements in the 2.0.x branch. The 1.x branch isn't actively maintained and won't receive new features anymore.

This will need a non-trivial reroll, there haven't been too many changes in the importer, but support for yaml/json was added and some things have been renamed.