Hi guys,

I was working on a custom Webform handler and some of the configuration was not getting updated when editing the handler config. It worked fine when creating a new one, but when editing some of the settings just didn't get saved.

So I looked around the code a bit and think I found a small issue where the handler instance config doesn't get saved on edit.

Can someone take a look at the patch and maybe we can get some feedback from the devs.

Appreciate it!

CommentFileSizeAuthor
webform_handler.patch734 bytesalecsmrekar
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

alecsmrekar created an issue. See original summary.

jrockowitz’s picture

jrockowitz CreditAttribution: jrockowitz at The Big Blue House commented
Status: Active » Needs review

@alecsmrekar You get the prize for issue of the day.

I just recently saw this issue while working with a handler that has an AJAX callback. I was completely baffled by it and was just starting to figure out this problem.

I am setting this patch to needs review to see if all the tests pass.

Here is the ticket I am working on to understand and resolve my Ajax related issues. #2860434: Create Test Ajax Submission Handler

jrockowitz’s picture

jrockowitz CreditAttribution: jrockowitz at The Big Blue House commented

All the tests are passing.

@alecsmrekar I am able to edit the 'Contact' form handlers without the patch. I am curious... What in your custom handler is triggering this issue? Is it Ajax?

alecsmrekar’s picture

alecsmrekar CreditAttribution: alecsmrekar commented

Exactly, I have 2 ajax fields. The second one is dependent on the first one and there's an ajax update when you change the first one. Other fields work fine.

jrockowitz’s picture

jrockowitz CreditAttribution: jrockowitz at The Big Blue House commented
Status: Needs review » Reviewed & tested by the community

The patch works perfectly with #2860434: Create Test Ajax Submission Handler.

@alecsmrekar I know you just wrote 5 line patch but I lost a few hours to this problem because I just could not see the issue properly. So thanks again.

  • jrockowitz committed ba60f53 on 8.x-5.x authored by alecsmrekar 
    Issue #2860453 by alecsmrekar: Webform handler config not being saved on...
jrockowitz’s picture

jrockowitz CreditAttribution: jrockowitz at The Big Blue House commented
Status: Reviewed & tested by the community » Fixed
alecsmrekar’s picture

alecsmrekar CreditAttribution: alecsmrekar commented

A fresh pair of eyes always helps, I'm glad we sorted it out :)

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.