Problem/Motivation

There is no way to open a UTF-8 csv file correctly with Excel on UNIX and Windows.

As reported here:
http://stackoverflow.com/questions/6588068/which-encoding-opens-csv-file...

This is the same issue for Drupal 8 as reported for Drupal 7.

Proposed resolution

I propose that the views interface provides an option to include signature (BOM) in the CSV data export.
Include signature BOM option (screenshot)

Remaining tasks

Reviews needed, tests to be written and run.

User interface changes

There is a new option in the CSV style options in the views interface that provides an option to include signature (BOM) in the CSV data export.

API changes

Data model changes

Original report by crystal_alexandre_froger (Drupal 7)

CSV export UTF-8 & windows - BOM (for Drupal 7)

CommentFileSizeAuthor
#12 views_data_export-add_optional_BOM_for_CSV-2859342-12.patch1.48 KBJuterpillar
#4 views_data_export-add_optional_BOM_for_CSV-2859342-4.patch1.27 KBJuterpillar
#3 views_data_export-add_optional_BOM_for_CSV-2859342-3.patch2.56 KBJuterpillar
#2 views_data_export-add_optional_BOM_for_CSV-2859342-2.patch2.56 KBJuterpillar
Screenshot from 2017-03-10 08:42:20.png25.59 KBJuterpillar
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Juterpillar created an issue. See original summary.

Juterpillar’s picture

Juterpillar CreditAttribution: Juterpillar at Catalyst IT commented
FileSize
views_data_export-add_optional_BOM_for_CSV-2859342-2.patch2.56 KB

I've attached a patch.
Please note this patch requires the patch from Support UTF-8 signature in export to work.

Juterpillar’s picture

Juterpillar CreditAttribution: Juterpillar at Catalyst IT commented
FileSize
views_data_export-add_optional_BOM_for_CSV-2859342-3.patch2.56 KB

I've attached another patch (messed up the last one, sorry!).
Please note this patch requires the patch from Support UTF-8 signature in export to work.

Juterpillar’s picture

Juterpillar CreditAttribution: Juterpillar at Catalyst IT commented
FileSize
views_data_export-add_optional_BOM_for_CSV-2859342-4.patch1.27 KB
matthewmessmer’s picture

matthewmessmer CreditAttribution: matthewmessmer commented
Status: Active » Reviewed & tested by the community
matthewmessmer’s picture

matthewmessmer CreditAttribution: matthewmessmer commented

Patch #4 fixed this issue for me.

undertext’s picture

undertext CreditAttribution: undertext as a volunteer commented

+1 RTBC
Patch looks good.

hgoto’s picture

hgoto CreditAttribution: hgoto at Studio Umi commented
Related issues: +#2859030: Support UTF-8 signature in export

I also tested the patch #4 with the patch #2859030-1: Support UTF-8 signature in export and it works well for me. Thank you.

khiminrm’s picture

khiminrm CreditAttribution: khiminrm at Lemberg Solutions commented

Patch from #4 works for me. Thanks!

dpi’s picture

dpi
Location Perth, Australia
CreditAttribution: dpi as a volunteer commented
Assigned: Juterpillar » Unassigned

There should probably be an entry in defineOptions

Otherwise, thanks, the patch looks good

dpi’s picture

dpi
Location Perth, Australia
CreditAttribution: dpi as a volunteer commented
Status: Reviewed & tested by the community » Needs work
Juterpillar’s picture

Juterpillar CreditAttribution: Juterpillar at Catalyst IT commented
FileSize
views_data_export-add_optional_BOM_for_CSV-2859342-12.patch1.48 KB

Thanks dpi,

I've updated the patch to include an entry in defineOptions.

Juterpillar’s picture

Juterpillar CreditAttribution: Juterpillar at Catalyst IT commented
Status: Needs work » Needs review
jibran’s picture

jibran
he/him
Primary language Urdu
Location Sydney, Australia
CreditAttribution: jibran as a volunteer and at PreviousNext commented
Status: Needs review » Reviewed & tested by the community

The module is still in beta so I don't think we need an upgrade path for this change other than that changes looks good to me.

  • jhedstrom committed c5aceb1 on 8.x-1.x authored by Juterpillar 
    Issue #2859342 by Juterpillar, dpi, matthewmessmer, undertext, hgoto,...
jhedstrom’s picture

jhedstrom
Primary language English
Location Portland, OR
CreditAttribution: jhedstrom at Phase2 for Workday, Inc. commented
Status: Reviewed & tested by the community » Fixed

Thanks all!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.