Many Microsoft software rely on UTF-8 signature(BOM) to determine file encoding.
Missing BOM can lead to strange side effects that is hard to understand.

CommentFileSizeAuthor
#5 csv_serialization-2859030-2-5-interdiff.txt1.12 KBRoSk0
#5 csv_serialization-2859030-5.patch1.68 KBRoSk0
#2 csv_serialization-2859030-2.patch1.67 KBRoSk0
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

RoSk0 created an issue. See original summary.

RoSk0’s picture

RoSk0
he/him
Primary language Russian
Location Wellington
CreditAttribution: RoSk0 at Catalyst IT for Land Information New Zealand commented
Assigned: RoSk0 » Unassigned
Status: Active » Needs review
FileSize
csv_serialization-2859030-2.patch1.67 KB

Patch to introduce optional BOM support in encode operations.

My colleague currently working on patch for Views Data Export module to provide UI for this option.
Will link to the issue when patch will be posted.

undertext’s picture

undertext CreditAttribution: undertext as a volunteer commented
Status: Needs review » Reviewed & tested by the community

Patch looks good and works for me.
Only one minor thing, maybe variable should be called $useUTF8Bom for more clarity.
Changing status to RTBC to get feedback from module maintainer.

hgoto’s picture

hgoto CreditAttribution: hgoto at Studio Umi commented

+1 to RTBC. And I agree with @undertext as for the variable name. Thanks.

RoSk0’s picture

RoSk0
he/him
Primary language Russian
Location Wellington
CreditAttribution: RoSk0 as a volunteer commented
FileSize
csv_serialization-2859030-5.patch1.68 KB
csv_serialization-2859030-2-5-interdiff.txt1.12 KB

Changed property name as requested.

hgoto’s picture

hgoto CreditAttribution: hgoto at Studio Umi commented

@RoSk0 thanks!

  • grasmash committed 12812ec on 8.x-1.x authored by RoSk0 
    Issue #2859030 by RoSk0: Support UTF-8 signature in export

grasmash credited grasmash.

grasmash’s picture

grasmash CreditAttribution: grasmash commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.