https://api.drupal.org/api/drupal/core!tests!Drupal!KernelTests!AssertLe...

CommentFileSizeAuthor
#3 webform-2.patch2.33 KBpifagor
webform-1.patch2.88 KBpifagor

Comments

pifagor created an issue. See original summary.

Pavan B S’s picture

Pavan B S commented
Status: Needs review » Needs work

After applying the patch , i got the following errors
error: while searching for:
* @see \Drupal\views\Tests\ViewTestData::createTestViews
*/
protected function loadWebform($id) {
$storage = \Drupal::entityManager()->getStorage('webform');
if ($webform = $storage->load($id)) {
return $webform;
}

error: patch failed: src/Tests/WebformTestBase.php:251
error: src/Tests/WebformTestBase.php: patch does not apply

pifagor’s picture

pifagor commented
Status: Needs work » Needs review
StatusFileSize
new webform-2.patch2.33 KB

patch

Pavan B S’s picture

Pavan B S commented
Status: Needs review » Reviewed & tested by the community

Thanks for the patch , it worked properly

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 3: webform-2.patch, failed testing.

pifagor’s picture

pifagor commented
Status: Needs work » Needs review
jrockowitz’s picture

jrockowitz commented

I understand the fix but I am not sure why patch #1 is okay and #2 is not.

pifagor’s picture

pifagor commented

Also not understand, manual all good. While in the first patch has some extra

jrockowitz’s picture

jrockowitz commented
Status: Needs review » Fixed

The WebformElementValidateUniqueTest has been throwing random failures. This patch is fine so I am going to commit it.

  • jrockowitz committed 7e42b8f on 8.x-5.x authored by pifagor 
    Issue #2858362 by pifagor: Deprecated method assertEqual removed from...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

pifagor’s picture

pifagor commented

Thank