I noticed that when was checking why new status page is broken in Seventeen theme. The overridden CSS files from Stable theme are still loaded. The issue is complicated by the fact that simple duplicating libraries-override is not possible because #2829372: libraries-override paths needs to be changed if they are base vs subtheme .

Steps to reproduce the issue:

  1. Create a subtheme of Seven theme which consists of just one info file (example).
  2. Install the theme and set it as site administration theme
  3. Navigate to admin/reports/status page and check if its appearance is the same as in Seven theme.

Comments

Chi created an issue. See original summary.

almaudoh’s picture

almaudoh commented
Related issues: +#2642122: Overriding already overridden libraries-override requires knowledge of previous libraries-overrides

This same bug is being fixed at #2642122: Overriding already overridden libraries-override requires knowledge of previous libraries-overrides. This issue is a duplicate.

chi’s picture

chi commented

I checked that thread before creating this one. From the issue summary this sounds as a different problem. In this case a sub theme has nothing to override by needs to preserve overrides made in base theme. The recent patch in #2642122 does not resolve the problem for me.

almaudoh’s picture

almaudoh commented

I'm not very clear on your issue. In HEAD any overrides in the base theme also affects the sub theme. If you want a subtheme to revert an override done in a base theme then you have to override the one done by the base theme.

Can you provide specific details of the Seventeen theme problem along with the libraries.yml file

chi’s picture

chi commented
Issue summary: View changes

In HEAD any overrides in the base theme also affects the sub theme.

Well, this does not work for me.

I've added steps to reproduce the bug to the issue summary.

chi’s picture

chi commented
Issue summary: View changes
almaudoh’s picture

almaudoh commented

The example .info.yml file references a seventeen/global library. Can you provide that library.yml or is it not required to reproduce the bug?

chi’s picture

chi commented

The file is in the same repository, but I am sure it isn't connected to the bug.
http://cgit.drupalcode.org/seventeen/tree/seventeen.libraries.yml?h=8.x-...

Version: 8.3.x-dev » 8.4.x-dev

Drupal 8.3.6 was released on August 2, 2017 and is the final full bugfix release for the Drupal 8.3.x series. Drupal 8.3.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.4.0 on October 4, 2017. (Drupal 8.4.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.4.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.5.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.4.x-dev » 8.5.x-dev

Drupal 8.4.4 was released on January 3, 2018 and is the final full bugfix release for the Drupal 8.4.x series. Drupal 8.4.x will not receive any further development aside from critical and security fixes. Sites should prepare to update to 8.5.0 on March 7, 2018. (Drupal 8.5.0-alpha1 is available for testing.)

Bug reports should be targeted against the 8.5.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.6.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.5.x-dev » 8.6.x-dev

Drupal 8.5.6 was released on August 1, 2018 and is the final bugfix release for the Drupal 8.5.x series. Drupal 8.5.x will not receive any further development aside from security fixes. Sites should prepare to update to 8.6.0 on September 5, 2018. (Drupal 8.6.0-rc1 is available for testing.)

Bug reports should be targeted against the 8.6.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.7.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

bskibinski’s picture

bskibinski
Primary language Dutch
Location Breda, The Netherlands
commented

I have the same issue, it is a seperate issue from the related issue. Or it might be related, but they're trying to fix the namespaces. This issue is about subthemes getting the overrides from the base_theme.

I made a basetheme with the following overrides:

libraries-override:
  contextual/drupal.contextual-links:
    css:
      component:
        /core/themes/stable/css/contextual/contextual.module.css: false
      theme:
        /core/themes/stable/css/contextual/contextual.theme.css: false
        /core/themes/stable/css/contextual/contextual.icons.theme.css: false
  contextual/drupal.contextual-toolbar:
    css:
      component:
        /core/themes/stable/css/contextual/contextual.toolbar.css: false
  system/base:
    css:
      component:
        /core/themes/stable/css/system/components/hidden.module.css: false

When the base theme is 'active/default', it works.
When i switch to a subtheme (based on the base-theme that has the overrides), the overrides don't work.

Workaround at the moment is to declare the same 'libraries-override' in every subtheme.

cedewey’s picture

cedewey
he/him
Primary language English
Location Denver, CO
commented

The patch in this issue resolves this problem for me - https://www.drupal.org/project/drupal/issues/2642122

Here's a working example - https://git.drupalcode.org/project/encontrarlo/commit/64bbcf8

Version: 8.6.x-dev » 8.8.x-dev

Drupal 8.6.x will not receive any further development aside from security fixes. Bug reports should be targeted against the 8.8.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.9.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.8.x-dev » 8.9.x-dev

Drupal 8.8.7 was released on June 3, 2020 and is the final full bugfix release for the Drupal 8.8.x series. Drupal 8.8.x will not receive any further development aside from security fixes. Sites should prepare to update to Drupal 8.9.0 or Drupal 9.0.0 for ongoing support.

Bug reports should be targeted against the 8.9.x-dev branch from now on, and new development or disruptive changes should be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.9.x-dev » 9.2.x-dev

Drupal 8 is end-of-life as of November 17, 2021. There will not be further changes made to Drupal 8. Bugfixes are now made to the 9.3.x and higher branches only. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.2.x-dev » 9.3.x-dev
larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented
Status: Active » Postponed (maintainer needs more info)
Issue tags: +Bug Smash Initiative

Is this still an issue?

There are conflicting reports of this being resolved by the related issue so it's not clear

aaronchristian’s picture

aaronchristian commented

I'm seeing this issue while using stable9 as my base.

It overrides a bunch of stylesheets in system/base. If you try to override/remove any of these replacements, the library system won't replace/remove stable9's with your custom themes.

chi’s picture

chi commented
Status: Postponed (maintainer needs more info) » Active

Updating the issue status per #19.

Version: 9.3.x-dev » 9.4.x-dev

Drupal 9.3.15 was released on June 1st, 2022 and is the final full bugfix release for the Drupal 9.3.x series. Drupal 9.3.x will not receive any further development aside from security fixes. Drupal 9 bug reports should be targeted for the 9.4.x-dev branch from now on, and new development or disruptive changes should be targeted for the 9.5.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.4.x-dev » 9.5.x-dev

Drupal 9.4.9 was released on December 7, 2022 and is the final full bugfix release for the Drupal 9.4.x series. Drupal 9.4.x will not receive any further development aside from security fixes. Drupal 9 bug reports should be targeted for the 9.5.x-dev branch from now on, and new development or disruptive changes should be targeted for the 10.1.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.5.x-dev » 11.x-dev

Drupal core is moving towards using a “main” branch. As an interim step, a new 11.x branch has been opened, as Drupal.org infrastructure cannot currently fully support a branch named main. New developments and disruptive changes should now be targeted for the 11.x branch. For more information, see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 11.x-dev » main

Drupal core is now using the main branch as the primary development branch. New developments and disruptive changes should now be targeted to the main branch.

Read more in the announcement.