This module have deprecated methods. Please, check up the patch for fix this problem.

CommentFileSizeAuthor
deprecated_methods.patch2.54 KBznak

Comments

Znak created an issue. See original summary.

nerdstein’s picture

nerdstein
he/him
Primary language English
Location United States
commented

Code review looks good. Waiting to see on tests.

nerdstein’s picture

nerdstein
he/him
Primary language English
Location United States
commented

Tests passed. I need to do some manual testing of this unless someone else beats me to it :)

nkoporec’s picture

nkoporec
Primary language English
Location Slovenia
commented
Status: Needs review » Reviewed & tested by the community

Manually tested the patch and it's working as expected.Since all test passed marking this as RTBC.

voleger’s picture

voleger
he/his
Primary language Ukrainian
Location Ukraine, Rivne
commented

+1 for RTBC

zahor’s picture

zahor commented

+1 Tested this. Looks good.

aohrvetpv’s picture

aohrvetpv commented

Thanks for the review/testing. I also did the following to test all these code changes:

1. Installed password_policy_history module. Verified that password_policy_history entries created for all existing users.

2. Installed password_policy_history module. Verified that password_policy_history entries created for all existing users. Deleted user. Verified entry for that user was deleted from password_policy_history.

3. Verified that policy names appear properly in "Password Policy" column of policy list.

4. Verified that PasswordManualRestTest passed.

Will commit/push shortly.

  • AohRveTPV committed f7d7e91 on 8.x-3.x authored by Znak 
    Issue #2856294 by Znak: Deprecated methods
aohrvetpv’s picture

aohrvetpv commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.