Hello

I try to collaborate when I can. I saw that Panels has a new version. You have 2 patches on it:

Patch in comment #2. Have a good coding :)
This time I searched in the issue cue for not to make you loose time ;)

CommentFileSizeAuthor
#8 panopoly_core-update-panels-3.9-2855737-8.patch948 bytesbyronveale
#7 panopoly_core-update-panels-3.9-2855737-7.patch948 bytesbyronveale
#6 panopoly_core-update-panels-3.9-2855737-6.patch848 bytesbyronveale
#2 panopoly_core-update-panels-3.9-2855737-2.patch848 bytescandelas

Comments

candelas created an issue. See original summary.

candelas’s picture

candelas commented
Component: Pages » Core
StatusFileSize
new panopoly_core-update-panels-3.9-2855737-2.patch848 bytes

The patch and it is Core, no Pages.

cboyden’s picture

cboyden commented
Status: Active » Needs review
dsnopek’s picture

dsnopek
he/him
Primary language English
Location USA
commented

Thanks for the patch!

Here's a Travis build:

https://travis-ci.org/panopoly/panopoly/builds/232594603

byronveale’s picture

byronveale commented

Evidently there was an issue with a misplaced resource for the new "CSS" button, that is fixed with this patch; you may want to incorporate this as well…

byronveale’s picture

byronveale commented
StatusFileSize
new panopoly_core-update-panels-3.9-2855737-6.patch848 bytes

Here's an attempt at patching the patch, to resolve the issue I mentioned in comment #5.

byronveale’s picture

byronveale commented
StatusFileSize
new panopoly_core-update-panels-3.9-2855737-7.patch948 bytes

I'm a doofus, didn't save my file before uploading, here we go again…!

byronveale’s picture

byronveale commented
StatusFileSize
new panopoly_core-update-panels-3.9-2855737-8.patch948 bytes

They say "practice makes perfect", let's hope so…

byronveale’s picture

byronveale commented

FWIW, that last patch worked locally…

dsnopek’s picture

dsnopek
he/him
Primary language English
Location USA
commented

Thanks! Here's a Travis build: https://travis-ci.org/panopoly/panopoly/builds/234127272

dsnopek’s picture

dsnopek
he/him
Primary language English
Location USA
commented

Here's a new Travis build after some attempts to fix the tests:

https://travis-ci.org/panopoly/panopoly/builds/235003659

dsnopek’s picture

dsnopek
he/him
Primary language English
Location USA
commented

The tests passed!

I was doing some manual testing, which looked good, when I discovered #2880513: Live preview not updating when typing in WYSIWYG -- it doesn't appear to be related to Panels 3.9, though, as switching back to 3.8 still shows that issue for me, so probably totally unrelated

  • dsnopek committed 9840fe9 on 7.x-1.x 
    Update Panopoly Core for Issue #2855737 by byronveale, candelas: Update...
dsnopek’s picture

dsnopek
he/him
Primary language English
Location USA
commented
Status: Needs review » Fixed

Everything seems good :-) Committed! Thanks, Everyone!

byronveale’s picture

byronveale commented

Thank you dsnopek, for this and all your other efforts…!

  • dsnopek committed 9840fe9 on 8.x-2.x 
    Update Panopoly Core for Issue #2855737 by byronveale, candelas: Update...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.