This is after applying the latest settings patch here ( https://www.drupal.org/node/2766471#comment-11944933 ) and regenerating the child theme. From inside the child theme:

$ npm start

> ourtheme@1.0.0 start /var/www/ourproject/public_html/themes/ourtheme
> gulp

[12:01:55] Using gulpfile /var/www/ourproject/public_html/themes/ourtheme/gulpfile.js
[12:01:55] Starting 'clean:css'...
[12:01:55] Starting 'drush:cc'...
[12:01:55] Starting 'lint:sass'...
[12:01:56] Finished 'clean:css' after 258 ms
[12:01:56] Starting 'sass'...

scss/_settings.scss
  113:24  warning  Don't include leading zeros on numbers  leading-zero
  159:31  warning  Don't include leading zeros on numbers  leading-zero
  181:24  warning  Don't include leading zeros on numbers  leading-zero
  182:27  warning  Don't include leading zeros on numbers  leading-zero
  224:17  warning  Don't include leading zeros on numbers  leading-zero
  226:19  warning  Don't include leading zeros on numbers  leading-zero
  236:27  warning  Don't include leading zeros on numbers  leading-zero
  243:18  warning  Don't include leading zeros on numbers  leading-zero
  252:9   warning  Don't include leading zeros on numbers  leading-zero
  253:10  warning  Don't include leading zeros on numbers  leading-zero
  254:12  warning  Don't include leading zeros on numbers  leading-zero
  258:27  warning  Don't include leading zeros on numbers  leading-zero
  261:38  warning  Don't include leading zeros on numbers  leading-zero
  261:60  warning  Don't include leading zeros on numbers  leading-zero
  277:41  warning  Don't include leading zeros on numbers  leading-zero
  302:10  warning  Don't include leading zeros on numbers  leading-zero
  306:10  warning  Don't include leading zeros on numbers  leading-zero
  307:11  warning  Don't include leading zeros on numbers  leading-zero
  320:34  warning  Don't include leading zeros on numbers  leading-zero
  383:45  warning  Don't include leading zeros on numbers  leading-zero
  386:31  warning  Don't include leading zeros on numbers  leading-zero
  386:50  warning  Don't include leading zeros on numbers  leading-zero
  398:19  warning  Don't include leading zeros on numbers  leading-zero
  399:17  warning  Don't include leading zeros on numbers  leading-zero
  399:28  warning  Don't include leading zeros on numbers  leading-zero
  414:21  warning  Don't include leading zeros on numbers  leading-zero
  417:21  warning  Don't include leading zeros on numbers  leading-zero
  437:42  warning  Don't include leading zeros on numbers  leading-zero
  441:31  warning  Don't include leading zeros on numbers  leading-zero
  444:42  warning  Don't include leading zeros on numbers  leading-zero
  453:23  warning  Don't include leading zeros on numbers  leading-zero
  454:27  warning  Don't include leading zeros on numbers  leading-zero
  455:30  warning  Don't include leading zeros on numbers  leading-zero
  456:41  warning  Don't include leading zeros on numbers  leading-zero
  458:47  warning  Don't include leading zeros on numbers  leading-zero
  508:42  warning  Don't include leading zeros on numbers  leading-zero
  513:25  warning  Don't include leading zeros on numbers  leading-zero
  514:25  warning  Don't include leading zeros on numbers  leading-zero
  515:17  warning  Don't include leading zeros on numbers  leading-zero
  521:27  warning  Don't include leading zeros on numbers  leading-zero
  536:24  warning  Don't include leading zeros on numbers  leading-zero
  538:32  warning  Don't include leading zeros on numbers  leading-zero
  583:43  warning  Don't include leading zeros on numbers  leading-zero
  584:59  warning  Don't include leading zeros on numbers  leading-zero
  593:20  warning  Don't include leading zeros on numbers  leading-zero
  597:25  warning  Don't include leading zeros on numbers  leading-zero
  606:19  warning  Don't include leading zeros on numbers  leading-zero
  608:21  warning  Don't include leading zeros on numbers  leading-zero
  609:43  warning  Don't include leading zeros on numbers  leading-zero
  615:18  warning  Don't include leading zeros on numbers  leading-zero
  618:24  warning  Don't include leading zeros on numbers  leading-zero
  618:36  warning  Don't include leading zeros on numbers  leading-zero

✖ 52 problems (0 errors, 52 warnings)


scss/kor_fdtn.scss
   1:1  warning  Multiline style comments should not be used  no-css-comments
  58:9  warning  Strings must use single quotes               quotes
  67:9  warning  Strings must use single quotes               quotes
  68:9  warning  Strings must use single quotes               quotes
  69:9  warning  Strings must use single quotes               quotes
  70:9  warning  Strings must use single quotes               quotes

✖ 6 problems (0 errors, 6 warnings)


scss/base/_common.scss
  7:43  warning  Files must end with a new line  final-newline

✖ 1 problem (0 errors, 1 warning)


scss/base/_elements.scss
  58:12  warning  Files must end with a new line  final-newline

✖ 1 problem (0 errors, 1 warning)


scss/base/_mixins.scss
  2:61  warning  Files must end with a new line  final-newline

✖ 1 problem (0 errors, 1 warning)


scss/layout/_header.scss
  1:53  warning  Files must end with a new line  final-newline

✖ 1 problem (0 errors, 1 warning)


scss/layout/_main.scss
  4:2   warning  Mixed tabs and spaces                                                        indentation
  4:20  warning  Color 'white' should be written in its hexadecimal form #ffffff              no-color-keywords
  4:20  warning  Color literals such as 'white' should only be used in variable declarations  no-color-literals
  5:1   warning  Files must end with a new line                                               final-newline

✖ 4 problems (0 errors, 4 warnings)
CommentFileSizeAuthor
#7 interdiff-2855460-5-7.txt2.04 KBsamuel.mortenson
#7 foundation-warnings-2855460-7.patch4.83 KBsamuel.mortenson
#5 foundation-warnings-2855460-5.patch2.72 KBsamuel.mortenson

Comments

HongPong created an issue. See original summary.

hongpong’s picture

hongpong commented
Issue summary: View changes
hongpong’s picture

hongpong commented

Patch here covers some of the warnings: #2854737: gulp watch fails with ''drush:cc' errored'

mariagwyn’s picture

mariagwyn commented

The two major groups of remaining warnings are:

  1. In `scss/_settings.scss` which is a direct copy of Zurbs settings.scss file, so we can't really change that so easily.
  2. In `newsubtheme/newsubtheme.scss`, multiline comments. Not sure how to get around that one as the comment is important.
samuel.mortenson’s picture

samuel.mortenson
he/him
Primary language English
commented
Status: Active » Needs review
StatusFileSize
new foundation-warnings-2855460-5.patch2.72 KB

I added a configuration option for ignored files from linting, which defaults to ignoring the settings file. Thoughts?

mariagwyn’s picture

mariagwyn commented

Honestly, I like the lint warnings, but think this is fine. Ideally, we should be able to exclude particular files, like the default zurb one since we can't fix that.

samuel.mortenson’s picture

samuel.mortenson
he/him
Primary language English
commented
StatusFileSize
new foundation-warnings-2855460-7.patch4.83 KB
new interdiff-2855460-5-7.txt2.04 KB

@mariagwyn You'll still get lint errors for everything _except_ the _settings.scss file :D

Updated patch fixes all STARTER theme lint warnings, I missed the no-css-comments rule (https://github.com/sasstools/sass-lint/blob/master/docs/rules/no-css-com...).

mariagwyn’s picture

mariagwyn commented

patch in #7 tested. works beautifully.

  • samuel.mortenson committed 8411e79 on 8.x-6.x 
    Issue #2855460 by samuel.mortenson, HongPong, mariagwyn: Minor warnings...
samuel.mortenson’s picture

samuel.mortenson
he/him
Primary language English
commented
Status: Needs review » Fixed

Woo-hoo! Clearing out the queue today.

hongpong’s picture

hongpong commented

Right on thanks for the quick turnaround on this. Best regards.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.