The PaymentInformation checkout pane #ajax doesn't always result in the gateway JS being loaded.
Citing ransomweaver in #2854145: Order payment method should be selectable and default:
Wow, this little change really blew up my payment gateway module! In causing an existing payment method to be selected by default, an unintended consequence is that the payment gateway doesn't load (at least for my module) the JS libraries in the initial payment information form, because buildCreditCardForm with $element['#attached']['library'][] is not run until ajax does it when you switch to add a new payment method.
This core ajax issue is implicated, I think: https://www.drupal.org/node/1988968
To work around this I have had to move my js library attaching to a hook_form_alter, which is not great since I have different js libs to load depending on test vs production, which is found from the gateway plugin config.
vasike also reported the same thing while working on checkout support for multiple gateways.
Comments
Comment #2
vasikeNow that we have #2827144: Support multiple payment gateways on Checkout Payment information pane
I think we need this, for me it smells like critical. Payment broken in checkout.
Comment #3
bojanz commentedAgreed.
Comment #5
bojanz commentedAPI expanded, Braintree updated to use it http://cgit.drupalcode.org/commerce_braintree/commit/?id=e2afa39
@vasike
Please update Stripe and Paymill.
Comment #6
sumanthkumarc commented@bojanz and @vasike , just created new issues at stripe: https://www.drupal.org/node/2861409 and Paymill: https://www.drupal.org/node/2861410 , trying to help :P
Comment #7
vasikeStripe and Paymill updated
@Bojan: what about keeping the library attach in buildCreditCardForm for Braintree?
http://cgit.drupalcode.org/commerce_braintree/tree/src/PluginForm/Hosted...
Comment #8
bojanz commentedThat's the module-specific form JS, which should stay there. Our problem is only with the dependencies of such JS files. (You can load one level via #ajax but not several)