+++ b/core/themes/seven/css/theme/maintenance-page.css
@@ -142,7 +142,7 @@
-    max-width: 770px;

+++ b/core/themes/seven/css/theme/maintenance-page.css
@@ -142,7 +142,7 @@
+    min-height: 75%;

These changes affect install page as well.

Screenshots before: https://www.drupal.org/files/issues/install-screen-before.png
Screenshot, after: https://www.drupal.org/files/issues/install-screen-after.png

CommentFileSizeAuthor
#13 install-iPad.png389.53 KBchrisrockwell
#13 install-iPhone.png340.17 KBchrisrockwell
#13 install-S5.png248.02 KBchrisrockwell
#13 install-s5-2.png253.62 KBchrisrockwell
#13 status-report-iPhone6plus.png68.64 KBchrisrockwell
#13 status-report-s5.png66.03 KBchrisrockwell
#13 update-iphone6plus.png114.86 KBchrisrockwell
#13 update-iphone6plus-2.png62.73 KBchrisrockwell
#9 without-revert-no-max-width.png112.04 KBchrisrockwell
#9 with-revert-max-770px.png106.36 KBchrisrockwell
#7 status_report_regression_to_update_and_install-2854851.patch487 byteschrisrockwell

Comments

yoroy created an issue. See original summary.

yoroy’s picture

yoroy commented

Originally reported by @Chi in https://www.drupal.org/node/665790?page=1#comment-11950598

Gábor Hojtsy credited Chi.

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented
Issue tags: +Usability, +sprint
chi’s picture

chi commented
Title: Max width change to status page affects installer screens as well, but shouldn't » Max width and min height change to status page affects installer screens as well, but shouldn't
Issue summary: View changes

min-height also changes appearance of that page.

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented
Related issues: +#665790: Redesign the status report page
chrisrockwell’s picture

chrisrockwell commented
StatusFileSize
new status_report_regression_to_update_and_install-2854851.patch487 bytes

Just reverts the change, this is affecting the update page as well. maintenance-page.css isn't used for the status report, should have just been left unchanged.

chrisrockwell’s picture

chrisrockwell commented
Status: Active » Needs review
chrisrockwell’s picture

chrisrockwell commented
StatusFileSize
new with-revert-max-770px.png106.36 KB
new without-revert-no-max-width.png112.04 KB

I see now this was done in comment #347. Because the status report render element is used on the update page, the extra width is nice there. I'm attaching a screenshot of what it looks like with 770px (reverting to default) and with the change in #347. I don't think it should be addressed here, but maybe we want to open a new issue to increase the width on the update page only?

Before:

With the change in #347

IMO it's nice to use the extra space if available on the update page.

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented
Status: Needs review » Reviewed & tested by the community

I don't think we need the wider width, especially not if it only applies to this screen, the installer is by design small because it has few things to say :) While this page says a bit more, I think it fits better if it stays within the small width. So looks like we can just roll back this part then.

Tested with this patch and it looks good in the installer too :)

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented

(Also tested the update page and it looked good too).

xjm’s picture

xjm
she/her
Primary language English
commented
Status: Reviewed & tested by the community » Needs review
Issue tags: +Needs screenshots

Can we also test on mobile? Thanks!

chrisrockwell’s picture

chrisrockwell commented
Issue tags: -Needs screenshots
StatusFileSize
new update-iphone6plus-2.png62.73 KB
new update-iphone6plus.png114.86 KB
new status-report-s5.png66.03 KB
new status-report-iPhone6plus.png68.64 KB
new install-s5-2.png253.62 KB
new install-S5.png248.02 KB
new install-iPhone.png340.17 KB
new install-iPad.png389.53 KB

Attaching several screenshots from within the Chrome emulator, including install screen, update screen, and status report.

yoroy’s picture

yoroy commented
Status: Needs review » Reviewed & tested by the community

Thank you Chris.

  • webchick committed 0885b37 on 8.3.x 
    Issue #2854851 by chrisrockwell, Chi: Max width and min height change to...

  • webchick committed c4c6521 on 8.4.x 
    Issue #2854851 by chrisrockwell, Chi: Max width and min height change to...
webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Status: Reviewed & tested by the community » Fixed

Committed and pushed to 8.3.x and 8.4.x. Thanks!

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented
Issue tags: -sprint

Yay, thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.