Hello,
It whould be great to have address/domain whitelist functionality for the Drupal 8 version of the Reroute Email.

This patch adds basic domain whitelist functionality based on patches from #1571500 Separate the recipient (list) from the address whitelist. Add domain whitelist.

Also provides small refactoring of the RerouteEmailSettings.php file:

  • added $this->t() usages
  • provided correct dependency injection
CommentFileSizeAuthor
#2 reroute_email_2854239_1.patch9.37 KBgilmord

Comments

gilmord created an issue. See original summary.

gilmord’s picture

gilmord
Location 🇺🇦Ukraine
commented
Status: Needs work » Needs review
StatusFileSize
new reroute_email_2854239_1.patch9.37 KB
gilmord’s picture

gilmord
Location 🇺🇦Ukraine
commented
Issue summary: View changes

Status: Needs review » Needs work

The last submitted patch, 2: reroute_email_2854239_1.patch, failed testing.

bohart’s picture

bohart
Location Lutsk, Ukraine
commented
Status: Needs work » Reviewed & tested by the community

This one used on three different projects for half a year.
Works like a charm!

bohart’s picture

bohart
Location Lutsk, Ukraine
commented
Status: Reviewed & tested by the community » Needs work

1) The patch should be re-rolled. Can't apply to current 8.x deb branch.

2) Instead of creating a new field in settings form, we can use current field and allow to set wildcard email like `*@drupal.org`, isn't it?

3) Backport for D7 should be done as well (Should we have a separate issue for that?).

bohart’s picture

bohart
Location Lutsk, Ukraine
commented
Status: Needs work » Postponed

Marked as postponed because of #2924078: Update settings form to have 2 emails fields.

bohart’s picture

bohart
Location Lutsk, Ukraine
commented
Status: Postponed » Fixed

Done for Drupal 8 at #2924078: Update settings form to have 2 emails fields.
Should be back-ported to Drupal 7 in that issue as well.

This one marked as fixed.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.