CommentFileSizeAuthor
#5 remove_the_variable_on-2853769-5.patch0 bytesdishabhadra
#3 remove_the_variable_on-2853769-3.patch516 bytesdishabhadra
#2 remove_the_variable_on-2853769-2.patch493 bytesdishabhadra

Comments

dishabhadra created an issue. See original summary.

dishabhadra’s picture

dishabhadra commented
Status: Active » Needs review
StatusFileSize
new remove_the_variable_on-2853769-2.patch493 bytes

Review my patch.

dishabhadra’s picture

dishabhadra commented
StatusFileSize
new remove_the_variable_on-2853769-3.patch516 bytes

Review this patch.

ashishdalvi’s picture

ashishdalvi
Primary language English
Location Mumbai
commented
Status: Needs review » Reviewed & tested by the community

Works fine. Thanks @disha for patch

dishabhadra’s picture

dishabhadra commented
Status: Reviewed & tested by the community » Needs review
StatusFileSize
new remove_the_variable_on-2853769-5.patch0 bytes

As I have done the research and found that in D8 no need to write the hook_uninstall for configuration delete.
It will automatically delete configuration when the module is uninstalled.

So I am removing that code and providing a patch.

Review it.

dishabhadra’s picture

dishabhadra commented

@kunal.kursija : As per my previous comment we don't need install file, So won't apply this patch and close this issue.

kunalkursija’s picture

kunalkursija commented
Assigned: dishabhadra » Unassigned
Status: Needs review » Closed (works as designed)

#2 and #3 should not work because this module does not uses State API.

And yes, Agreed with #5. We won't need such feature as Drupal Core does this job out of the box.

Closing the issue.