Fix typo in age_calculator.helper_functions.inc file.

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Shashwat Purav created an issue. See original summary.

Shashwat Purav’s picture

Assigned: Shashwat Purav » Unassigned
Status: Active » Needs review
FileSize
374 bytes

Fixed typo in age_calculator.helper_functions.inc file. Added patch.

krina.addweb’s picture

Status: Needs review » Needs work

@Shashwat Purav,Thanks for the patch, but there are some more typos in the age_calculator.helper_functions.inc file which needs to be corrected.

  // If the configrations are not saved by admin, we shall use the default one.

Here, Spelling of "configrations" should be "Configurations"

// Fetching the defult configuration.

Here, Spelling of "defult" should be "default"

shruti1803’s picture

Status: Needs work » Needs review
FileSize
1.05 KB

Make changes as said by @krina.addweb . Please review

krina.addweb’s picture

FileSize
20.73 KB

@shruti1803, I think your corrections are right but your patch not applied correctly & throws:
PFA

Krina@Krina-PC MINGW32 ~/downloads/age_calculator
$ patch < typo_in-2853754-4.patch.txt
patching file age_calculator.helper_functions.inc
Hunk #1 FAILED at 6 (different line endings).
Hunk #2 FAILED at 21 (different line endings).
2 out of 2 hunks FAILED -- saving rejects to file age_calculator.helper_functions.inc.rej

dishabhadra’s picture

Assigned: Unassigned » dishabhadra
dishabhadra’s picture

@krina.addweb : For this issue #2 patch is perfect. Because the changes you have mention for that one issue is created and added the patch here https://www.drupal.org/node/2826827.

So no need to consider the #4 changes for this issue.

krina.addweb’s picture

@dishabhadra, Yes you were right #2 works well, thanks for the referred post.

krina.addweb’s picture

Status: Needs review » Reviewed & tested by the community
kunalkursija’s picture

Assigned: dishabhadra » Unassigned
Status: Reviewed & tested by the community » Fixed

Thanks for the #2 @Shashwat Purav.
Have Committed to new 8.x-2.x branch, Will be creating the release soon.

kunalkursija’s picture

Thank you for the contribution guys.
I have added a new release that fixes this issue.
Here is 8.x-2.0 release: https://www.drupal.org/project/age_calculator/releases/8.x-2.0.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.