Closed (fixed)
Project:
Age Calculator
Version:
8.x-1.0
Component:
Documentation
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
18 Feb 2017 at 07:56 UTC
Updated:
15 Jan 2018 at 12:19 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
shashwat purav commentedFixed typo in age_calculator.helper_functions.inc file. Added patch.
Comment #3
krina.addweb commented@Shashwat Purav,Thanks for the patch, but there are some more typos in the age_calculator.helper_functions.inc file which needs to be corrected.
Here, Spelling of "configrations" should be "Configurations"
Here, Spelling of "defult" should be "default"
Comment #4
shruti1803 commentedMake changes as said by @krina.addweb . Please review
Comment #5
krina.addweb commented@shruti1803, I think your corrections are right but your patch not applied correctly & throws:
PFA
Comment #6
dishabhadra commentedComment #7
dishabhadra commented@krina.addweb : For this issue #2 patch is perfect. Because the changes you have mention for that one issue is created and added the patch here https://www.drupal.org/node/2826827.
So no need to consider the #4 changes for this issue.
Comment #8
krina.addweb commented@dishabhadra, Yes you were right #2 works well, thanks for the referred post.
Comment #9
krina.addweb commentedComment #10
kunalkursija commentedThanks for the #2 @Shashwat Purav.
Have Committed to new 8.x-2.x branch, Will be creating the release soon.
Comment #11
kunalkursija commentedThank you for the contribution guys.
I have added a new release that fixes this issue.
Here is 8.x-2.0 release: https://www.drupal.org/project/age_calculator/releases/8.x-2.0.