Install file porting.

CommentFileSizeAuthor
#13 port_port_install_file-2853740-13.patch225 bytesdishabhadra
#10 port_port_install_file-2853740-10.patch3.4 KBdishabhadra
#6 port_port_install_file-2853740-6.patch2.23 KBdishabhadra
#5 port_port_install_file-2853740-5.patch2.45 KBdishabhadra
#3 first_time_login.install.tar_.gz806 bytesdishabhadra

Comments

kunal.kursija created an issue. See original summary.

dishabhadra’s picture

dishabhadra commented
Assigned: Unassigned » dishabhadra

I am working on it.

dishabhadra’s picture

dishabhadra commented
Status: Active » Needs review
StatusFileSize
new first_time_login.install.tar_.gz806 bytes

I ported install file into D8 version.

Kindly review my file and add it into module file.

ashishdalvi’s picture

ashishdalvi
Primary language English
Location Mumbai
commented
Version: 7.x-2.1 » 8.x-1.x-dev

Hi Disha,

As we have 8.x.-1.x branch available. Please create a patch for same issue.

Thanks

dishabhadra’s picture

dishabhadra commented
StatusFileSize
new port_port_install_file-2853740-5.patch2.45 KB

I applied patch in 8.x-1.x Branch.

Review my patch.

dishabhadra’s picture

dishabhadra commented
StatusFileSize
new port_port_install_file-2853740-6.patch2.23 KB

As I have done the research and found that in D8 no need to write the hook_uninstall for configuration delete.
It will automatically delete configuration when the module is uninstalled.

So I am removing that code and providing a patch.

Review it.

kunalkursija’s picture

kunalkursija commented
Status: Needs review » Reviewed & tested by the community

@dishabhadra : Yes configurations are getting deleted automatically.

Patch is working: Changing status to RTBC.

neerajsingh’s picture

neerajsingh
Primary language English
Location IN 🇮🇳
commented
Status: Reviewed & tested by the community » Needs work

I have committed the patch at #6, but faced few whitespace related warnings. 

$ git apply -v ../patch/port_port_install_file-2853740-6.patch
../patch/port_port_install_file-2853740-6.patch:7: trailing whitespace.
<?php
../patch/port_port_install_file-2853740-6.patch:8: trailing whitespace.

../patch/port_port_install_file-2853740-6.patch:9: trailing whitespace.
/**
../patch/port_port_install_file-2853740-6.patch:10: trailing whitespace.
 * @file
../patch/port_port_install_file-2853740-6.patch:11: trailing whitespace.
 * Install function for the first login module.
Checking patch first_time_login.install...
Applied patch first_time_login.install cleanly.
warning: squelched 74 whitespace errors
warning: 79 lines add whitespace errors.

Please re-roll the patch.

dishabhadra’s picture

dishabhadra commented
Status: Needs work » Needs review
StatusFileSize
new port_port_install_file-2853740-10.patch3.4 KB

@neerajsingh : Thank you for commit.

As per Drupal Standards I have fixes the Warning.

Please check.

kunalkursija’s picture

kunalkursija commented
Status: Needs review » Reviewed & tested by the community 
user@F884:~/Desktop/first_time_login$ git apply -v /home/user/Desktop/port_port_install_file-2853740-10.patch
Checking patch config/install/first_time_login.settings.yml...
Checking patch first_time_login.install...
Checking patch first_time_login.module...
Checking patch first_time_login.routing.yml...
Checking patch src/Form/FirstTimeLoginSettings.php...
Applied patch config/install/first_time_login.settings.yml cleanly.
Applied patch first_time_login.install cleanly.
Applied patch first_time_login.module cleanly.
Applied patch first_time_login.routing.yml cleanly.
Applied patch src/Form/FirstTimeLoginSettings.php cleanly

Patch applied cleanly, Changing to RTBC.

neerajsingh’s picture

neerajsingh
Primary language English
Location IN 🇮🇳
commented
Status: Reviewed & tested by the community » Needs work

After applying the patch at #11 from #2853737: Port - Admin Config Form | Module API's | Variables, patch at #10 does not apply any more... would need another re-roll.

dishabhadra’s picture

dishabhadra commented
Status: Needs work » Needs review
StatusFileSize
new port_port_install_file-2853740-13.patch225 bytes

I re-roll the patch.

neerajsingh’s picture

neerajsingh
Primary language English
Location IN 🇮🇳
commented
Status: Needs review » Fixed

Thanks dishabhadra, for the patch.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.