Port the configuration form.

CommentFileSizeAuthor
#10 port_admin_config-2853737-10.patch3.18 KBdishabhadra
#6 port_admin_config-2853737-6.patch11.06 KBdishabhadra

Comments

kunal.kursija created an issue. See original summary.

kunalkursija’s picture

kunalkursija commented
Title: Port - Admin Config Form to D8 » Port - Admin Config Form | Module API's | Variables

1) Port the variables via configuration system.
2) Port the form by creating routing & form.
3) Port the module file into Drupal 8 & relevant api's.

dishabhadra’s picture

dishabhadra commented
Assigned: Unassigned » dishabhadra

I am working on it.

ashishdalvi’s picture

ashishdalvi
Primary language English
Location Mumbai
commented
Version: 7.x-2.2 » 8.x-1.x-dev

As we have 8.x.-1.x branch available. Updating the issues meta data

ashishdalvi’s picture

ashishdalvi
Primary language English
Location Mumbai
commented
dishabhadra’s picture

dishabhadra commented
Status: Active » Needs review
StatusFileSize
new port_admin_config-2853737-6.patch11.06 KB

I applied patch in 8.x-1.x branch.

Configuration form is included. Configuration is also added.

Review my patch.

kunalkursija’s picture

kunalkursija commented
Status: Needs review » Reviewed & tested by the community

Patch is working: Changing status to RTBC.

neerajsingh’s picture

neerajsingh
Primary language English
Location IN 🇮🇳
commented
Status: Reviewed & tested by the community » Needs work

Committed with below warnings, please re-roll the fix.

$ git apply -v ../patch/port_admin_config-2853737-6.patch
../patch/port_admin_config-2853737-6.patch:7: trailing whitespace.
first_time_login_config_days: 120
../patch/port_admin_config-2853737-6.patch:8: trailing whitespace.
first_time_login_new_user_message: Welcome @user to @site_name your account was created on '@created_date'. Please update your account's details.
../patch/port_admin_config-2853737-6.patch:9: trailing whitespace.
first_time_login_update_user_message: Welcome @user to @site_name your account was updated on '@updated_date'. Please update your account's details.
../patch/port_admin_config-2853737-6.patch:17: trailing whitespace.
first_time_login.settings:
../patch/port_admin_config-2853737-6.patch:18: trailing whitespace.
  type: config_object
Checking patch config/install/first_time_login.settings.yml...
Checking patch config/schema/first_time_login.schema.yml...
Checking patch first_time_login.links.menu.yml...
Checking patch first_time_login.module...
Checking patch first_time_login.routing.yml...
Checking patch src/Form/FirstTimeLoginSettings.php...
Applied patch config/install/first_time_login.settings.yml cleanly.
Applied patch config/schema/first_time_login.schema.yml cleanly.
Applied patch first_time_login.links.menu.yml cleanly.
Applied patch first_time_login.module cleanly.
Applied patch first_time_login.routing.yml cleanly.
Applied patch src/Form/FirstTimeLoginSettings.php cleanly.
warning: squelched 260 whitespace errors
warning: 265 lines add whitespace errors.
dishabhadra’s picture

dishabhadra commented
Status: Needs work » Needs review
StatusFileSize
new port_admin_config-2853737-10.patch3.18 KB

@neerajsingh : Thank you for commit.

As per Drupal Standards I have fixes the Warning.

Please check.

kunalkursija’s picture

kunalkursija commented
Status: Needs review » Reviewed & tested by the community 
user@F884:~/Desktop/first_time_login$ git apply -v /home/user/Desktop/port_admin_config-2853737-10.patch
Checking patch config/install/first_time_login.settings.yml...
Checking patch first_time_login.module...
Checking patch first_time_login.routing.yml...
Checking patch src/Form/FirstTimeLoginSettings.php...
Applied patch config/install/first_time_login.settings.yml cleanly.
Applied patch first_time_login.module cleanly.
Applied patch first_time_login.routing.yml cleanly.
Applied patch src/Form/FirstTimeLoginSettings.php cleanly.

Patch applied successfully without any warnings. Changing to RTBC.

neerajsingh’s picture

neerajsingh
Primary language English
Location IN 🇮🇳
commented
Status: Reviewed & tested by the community » Fixed

Thanks dishabhadra, for the updated patch.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.