Patch (to be ported)
Project:
Video Embed Vidyard
Version:
7.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
17 Feb 2017 at 18:14 UTC
Updated:
21 May 2019 at 05:27 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
recrit commentedThe attached patch updates the regex in getIdFromInput() to support the embed_select url.
Comment #3
recrit commentedImproved detection using parse_url and supporting the following forms:
'https://secure.vidyard.com/embed_select/A1B_C2D345E-fg-hijKL6M'
'http://embed.vidyard.com/share/A1B_C2D345E-fg-hijKL6M
'https://secure.vidyard.com/organizations/12345/embed_select/A1B_C2D345E-...'
Comment #4
eric115 commentedGreat patch!
I have added some unit tests in to check URL parsing.
Comment #5
eric115 commentedUpdating for drupal-ci to test these patches
Comment #6
eric115 commentedComment #8
eric115 commentedCommitted, thanks for your patch @recrit!
Marking this to be ported to the 7.x version
Comment #9
osmanThis is an old issue now, but is
embed_selectstill valid for sharable URLs?The example URL in the description doesn't work anymore, also I couldn't find any reference to it in Vinyard documentations, except for the "Developer Web Embed" URL.
All the patterns I could find:
Comment #10
eric115 commentedIt's quite possible it's changed now. I haven't worked with vidyard for quite a while and this module was written a few years ago.
It might be worth creating a new issue for this change if you would like to patch it, I think you can still use the module by using the custom url options, but it would be good to update the examples if people are still using this module.